GNU bug report logs - #29535
[PATCH] gnu: Add cli-visualizer.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29535 in the body.
You can then email your comments to 29535 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add cli-visualizer.
Date: Sat, 02 Dec 2017 22:05:36 +0300

[0001-gnu-Add-cli-visualizer.patch (text/x-patch, inline)]

From 54a00afb4e628019dbfe3f9b7f09a553dab3cfb9 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 2 Dec 2017 22:03:13 +0300
Subject: [PATCH] gnu: Add cli-visualizer.

* gnu/packages/audio.scm (cli-visualizer): New variable.
---
 gnu/packages/audio.scm | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index da9314392..6ca250f0c 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3087,3 +3087,43 @@ mixers.")
 customized and extended using either the s7 Scheme implementation (included in
 the Snd sources), Ruby, or Forth.")
     (license (license:non-copyleft "file://COPYING"))))
+
+(define-public cli-visualizer
+  (package
+    (name "cli-visualizer")
+    (version "1.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/dpayne/cli-visualizer/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07zkm87f2fr8kc6531zrkya7q81sdanm6813y2f54mg13g41y6hi"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("fftw"       ,fftw)
+       ("ncurses"    ,ncurses)
+       ("pulseaudio" ,pulseaudio)
+       ("which"      ,which)))
+    (arguments
+     '(#:tests? #f ; no tests
+       #:make-flags
+       (list (string-append "PREFIX=" %output "/bin/") "ENABLE_PULSE=1")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'remove-sudo
+           (lambda _ (substitute* "install.sh" (("sudo") ""))))
+         (add-before 'install 'make-prefix
+           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/bin"))))
+         (add-after 'install 'data
+           (lambda _ (for-each (lambda (file)
+                            (install-file file "/share/doc"))
+                          (list "asound_alsa.conf" "asound_alsa_with_dmix.conf"
+                                "basic_colors" "blue" "config" "rainbow")))))))
+    (home-page "https://github.com/dpayne/cli-visualizer/")
+    (synopsis "CLI audio visualizer")
+    (description "@code{cli-visualizer} provides a command line audio
+visualizer for MPD, Alsa and Pulseaudio.")
+    (license license:expat)))
-- 
2.15.0

Message #8 received at 29535 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: bug#29535 <29535 <at> debbugs.gnu.org>
Subject: Re: Status: [PATCH] gnu: Add cli-visualizer.
Date: Sun, 03 Dec 2017 10:36:10 +0300

[0001-gnu-Add-cli-visualizer.patch (text/x-patch, inline)]

From 83d6e5b19813bc53a638f6fbbc007621a9a58648 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 2 Dec 2017 22:03:13 +0300
Subject: [PATCH] gnu: Add cli-visualizer.

* gnu/packages/audio.scm (cli-visualizer): New variable.
---
 gnu/packages/audio.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index da9314392..3816cf98f 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -3087,3 +3087,45 @@ mixers.")
 customized and extended using either the s7 Scheme implementation (included in
 the Snd sources), Ruby, or Forth.")
     (license (license:non-copyleft "file://COPYING"))))
+
+(define-public cli-visualizer
+  (package
+    (name "cli-visualizer")
+    (version "1.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/dpayne/cli-visualizer/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "07zkm87f2fr8kc6531zrkya7q81sdanm6813y2f54mg13g41y6hi"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("fftw"       ,fftw)
+       ("ncurses"    ,ncurses)
+       ("pulseaudio" ,pulseaudio)
+       ("which"      ,which)))
+    (arguments
+     '(#:tests? #f ; no tests
+       #:make-flags
+       (list (string-append "PREFIX=" %output "/bin/") "ENABLE_PULSE=1")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'remove-sudo
+           (lambda _ (substitute* "install.sh" (("sudo") ""))))
+         (add-before 'install 'make-prefix
+           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/bin"))))
+         (add-after 'install 'data
+           (lambda _
+             (for-each (lambda (file)
+                         (install-file file
+                                       (string-append (assoc-ref %outputs "out")
+                                                      "/share/doc")))
+                       (find-files "examples")))))))
+    (home-page "https://github.com/dpayne/cli-visualizer/")
+    (synopsis "CLI audio visualizer")
+    (description "@code{cli-visualizer} provides a command line audio
+visualizer for MPD, Alsa and Pulseaudio.")
+    (license license:expat)))
-- 
2.15.0

Message #11 received at 29535 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29535 <at> debbugs.gnu.org
Subject: Re: [bug#29535] [PATCH] gnu: Add cli-visualizer.
Date: Tue, 05 Dec 2017 13:46:15 +0100

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

>>From 54a00afb4e628019dbfe3f9b7f09a553dab3cfb9 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sat, 2 Dec 2017 22:03:13 +0300
> Subject: [PATCH] gnu: Add cli-visualizer.
>
> * gnu/packages/audio.scm (cli-visualizer): New variable.

[...]

> +    (inputs
> +     `(("fftw"       ,fftw)
> +       ("ncurses"    ,ncurses)
> +       ("pulseaudio" ,pulseaudio)
> +       ("which"      ,which)))

Most likely ‘which’ should be in ‘native-inputs’ (it’s not referred to
at run time, is it?).

Besides, I’d encourage you to not align inputs like this, for
consistency with the rest of the code, though that’s not that big a
deal.  :-)

> +         (add-after 'unpack 'remove-sudo
> +           (lambda _ (substitute* "install.sh" (("sudo") ""))))
> +         (add-before 'install 'make-prefix
> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/bin"))))
> +         (add-after 'install 'data
> +           (lambda _ (for-each (lambda (file)
> +                            (install-file file "/share/doc"))
> +                          (list "asound_alsa.conf" "asound_alsa_with_dmix.conf"
> +                                "basic_colors" "blue" "config" "rainbow")))))))


Nitpick: please write the lambda’s body on a separate line, and make
sure each phase returns a Boolean:

  (lambda _
    (substitute* …)
    #t)

> +    (synopsis "CLI audio visualizer")

s/CLI/Command-line/

> +    (description "@code{cli-visualizer} provides a command line audio
> +visualizer for MPD, Alsa and Pulseaudio.")

s/Alsa/ALSA/

It would be nice if you could clarify in the description what “audio
visualizer” means.  Perhaps something like:

  It can display fast-Fourier transforms (FFTs) of the sound being
  played, as well as other graphical representations.

OK with these changes, thank you!

Ludo’.

Message #14 received at 29535 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29535 <at> debbugs.gnu.org, 29535-done <at> debbugs.gnu.org
Subject: Re: [bug#29535] [PATCH] gnu: Add cli-visualizer.
Date: Tue, 12 Dec 2017 00:09:16 +0300

[Message part 1 (text/plain, inline)]

Hello Ludovic,

Thank you for review!

ludo <at> gnu.org (Ludovic Courtès) writes:

> [...]
>
> OK with these changes, thank you!

I applied all your notes and also found included tests in cli-visualizer

Pushed as adedbe95d4896c86c26b2b3ad8408e49f52e9796

Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.