GNU bug report logs - #29535
[PATCH] gnu: Add cli-visualizer.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 29535 <at> debbugs.gnu.org
Subject: [bug#29535] [PATCH] gnu: Add cli-visualizer.
Date: Tue, 05 Dec 2017 13:46:15 +0100

Oleg Pykhalov <go.wigust <at> gmail.com> skribis:

>>From 54a00afb4e628019dbfe3f9b7f09a553dab3cfb9 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sat, 2 Dec 2017 22:03:13 +0300
> Subject: [PATCH] gnu: Add cli-visualizer.
>
> * gnu/packages/audio.scm (cli-visualizer): New variable.

[...]

> +    (inputs
> +     `(("fftw"       ,fftw)
> +       ("ncurses"    ,ncurses)
> +       ("pulseaudio" ,pulseaudio)
> +       ("which"      ,which)))

Most likely ‘which’ should be in ‘native-inputs’ (it’s not referred to
at run time, is it?).

Besides, I’d encourage you to not align inputs like this, for
consistency with the rest of the code, though that’s not that big a
deal.  :-)

> +         (add-after 'unpack 'remove-sudo
> +           (lambda _ (substitute* "install.sh" (("sudo") ""))))
> +         (add-before 'install 'make-prefix
> +           (lambda _ (mkdir-p (string-append (assoc-ref %outputs "out") "/bin"))))
> +         (add-after 'install 'data
> +           (lambda _ (for-each (lambda (file)
> +                            (install-file file "/share/doc"))
> +                          (list "asound_alsa.conf" "asound_alsa_with_dmix.conf"
> +                                "basic_colors" "blue" "config" "rainbow")))))))


Nitpick: please write the lambda’s body on a separate line, and make
sure each phase returns a Boolean:

  (lambda _
    (substitute* …)
    #t)

> +    (synopsis "CLI audio visualizer")

s/CLI/Command-line/

> +    (description "@code{cli-visualizer} provides a command line audio
> +visualizer for MPD, Alsa and Pulseaudio.")

s/Alsa/ALSA/

It would be nice if you could clarify in the description what “audio
visualizer” means.  Perhaps something like:

  It can display fast-Fourier transforms (FFTs) of the sound being
  played, as well as other graphical representations.

OK with these changes, thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.