GNU bug report logs - #29417
erc.el enables minor modes on load

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29417: closed (erc.el enables minor modes on load)
Date: Mon, 04 Dec 2017 03:01:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 03 Dec 2017 21:59:56 -0500
with message-id <7fefobqjtf.fsf <at> fencepost.gnu.org>
and subject line Re: bug#29417: 26.0.90: minor modes enabled after C-h f
has caused the debbugs.gnu.org bug report #29417,
regarding erc.el enables minor modes on load
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29417: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29417
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: charles <at> aurox.ch (Charles A. Roelli)
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90: minor modes enabled after C-h f
Date: Thu, 23 Nov 2017 21:20:59 +0100

From emacs -q on the pretest,

C-h f erc- TAB C-g

C-h m:

Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption
Blink-Cursor Electric-Indent Erc-Autojoin Erc-Button Erc-Fill
Erc-Irccontrols Erc-List Erc-Match Erc-Menu Erc-Move-To-Prompt
Erc-Netsplit Erc-Networks Erc-Noncommands Erc-Pcomplete Erc-Readonly
Erc-Ring Erc-Stamp Erc-Track File-Name-Shadow Global-Eldoc
Global-Font-Lock Line-Number Menu-Bar Mouse-Wheel Tool-Bar Tooltip
Transient-Mark

The Erc-* minor modes should not be enabled.

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 29417-done <at> debbugs.gnu.org
Subject: Re: bug#29417: 26.0.90: minor modes enabled after C-h f
Date: Sun, 03 Dec 2017 21:59:56 -0500

Version: 26.0.91

commit e9ea206 (HEAD, origin/emacs-26, emacs-26)
Date:   Sun Dec 3 18:54:08 2017 -0800

    Don't enable erc modules on simply loading erc.el
    
    * lisp/erc/erc.el (erc-modules): Use default :initialize.  (Bug#29417)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 5fe4f9a..d75209a 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1832,6 +1832,7 @@ erc-modules
   :get (lambda (sym)
          ;; replace outdated names with their newer equivalents
          (erc-migrate-modules (symbol-value sym)))
+  :initialize 'custom-initialize-default
   :set (lambda (sym val)
          ;; disable modules which have just been removed
          (when (and (boundp 'erc-modules) erc-modules val)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.