GNU bug report logs - #29417
erc.el enables minor modes on load

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29417 in the body.
You can then email your comments to 29417 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90: minor modes enabled after C-h f
Date: Thu, 23 Nov 2017 21:20:59 +0100

From emacs -q on the pretest,

C-h f erc- TAB C-g

C-h m:

Enabled minor modes: Auto-Composition Auto-Compression Auto-Encryption
Blink-Cursor Electric-Indent Erc-Autojoin Erc-Button Erc-Fill
Erc-Irccontrols Erc-List Erc-Match Erc-Menu Erc-Move-To-Prompt
Erc-Netsplit Erc-Networks Erc-Noncommands Erc-Pcomplete Erc-Readonly
Erc-Ring Erc-Stamp Erc-Track File-Name-Shadow Global-Eldoc
Global-Font-Lock Line-Number Menu-Bar Mouse-Wheel Tool-Bar Tooltip
Transient-Mark

The Erc-* minor modes should not be enabled.

Message #8 received at 29417 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 29417 <at> debbugs.gnu.org
Subject: Re: bug#29417: 26.0.90: minor modes enabled after C-h f
Date: Thu, 23 Nov 2017 18:45:45 -0500

[Message part 1 (text/plain, inline)]

merge 29417 28607
quit

charles <at> aurox.ch (Charles A. Roelli) writes:

> C-h f erc- TAB C-g

> The Erc-* minor modes should not be enabled.

I believe this is a dup of #28607 "27.0.50; help-fns unsolicited elisp loading".

[erc-menu-debug-watch-backtrace.txt (text/plain, attachment)]

Message #13 received at 29417 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: "Charles A. Roelli" <charles <at> aurox.ch>, 29417 <at> debbugs.gnu.org
Subject: Re: bug#29417: 26.0.90: minor modes enabled after C-h f
Date: Thu, 23 Nov 2017 19:40:19 -0500

Noam Postavsky wrote:

> I believe this is a dup of #28607 "27.0.50; help-fns unsolicited elisp loading".

I think it is a separate, erc-specific issue which that feature happens
to reveal. Simply loading a lisp file is not supposed to enable modes
and such, and yet eg

emacs -Q -l erc-fill

does.

Message #16 received at 29417 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: Glenn Morris <rgm <at> gnu.org>
Cc: "Charles A. Roelli" <charles <at> aurox.ch>, 29417 <at> debbugs.gnu.org
Subject: Re: bug#29417: 26.0.90: minor modes enabled after C-h f
Date: Thu, 23 Nov 2017 22:26:47 -0500

unmerge 29417
quit

Glenn Morris <rgm <at> gnu.org> writes:

> I think it is a separate, erc-specific issue which that feature happens
> to reveal. Simply loading a lisp file is not supposed to enable modes
> and such, and yet eg
>
> emacs -Q -l erc-fill
>
> does.

Hmm, okay.  I don't really use erc, so I thought the mode enabling on
load was on purpose.

Message #23 received at 29417 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Noam Postavsky <npostavs <at> users.sourceforge.net>
Cc: "Charles A. Roelli" <charles <at> aurox.ch>, 29417 <at> debbugs.gnu.org
Subject: Re: bug#29417: 26.0.90: minor modes enabled after C-h f
Date: Tue, 28 Nov 2017 13:58:32 -0500

Since erc-open runs erc-update-modules, I think this might work.
It fixes the issue, but I'm not an ERC user.

--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1845,6 +1845,7 @@ erc-modules
   :get (lambda (sym)
          ;; replace outdated names with their newer equivalents
          (erc-migrate-modules (symbol-value sym)))
+  :initialize 'custom-initialize-default
   :set (lambda (sym val)
          ;; disable modules which have just been removed
          (when (and (boundp 'erc-modules) erc-modules val)

Message #28 received at 29417-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 29417-done <at> debbugs.gnu.org
Subject: Re: bug#29417: 26.0.90: minor modes enabled after C-h f
Date: Sun, 03 Dec 2017 21:59:56 -0500

Version: 26.0.91

commit e9ea206 (HEAD, origin/emacs-26, emacs-26)
Date:   Sun Dec 3 18:54:08 2017 -0800

    Don't enable erc modules on simply loading erc.el
    
    * lisp/erc/erc.el (erc-modules): Use default :initialize.  (Bug#29417)

diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
index 5fe4f9a..d75209a 100644
--- a/lisp/erc/erc.el
+++ b/lisp/erc/erc.el
@@ -1832,6 +1832,7 @@ erc-modules
   :get (lambda (sym)
          ;; replace outdated names with their newer equivalents
          (erc-migrate-modules (symbol-value sym)))
+  :initialize 'custom-initialize-default
   :set (lambda (sym val)
          ;; disable modules which have just been removed
          (when (and (boundp 'erc-modules) erc-modules val)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.