GNU bug report logs - #29413
Add inputs for pcmanfm and a CVE-2017-8934 patch

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: brendan.tildesley <at> openmailbox.org
Subject: bug#29413: closed (Re: [bug#29413] Add inputs for pcmanfm and a
 CVE-2017-8934 patch)
Date: Thu, 23 Nov 2017 21:57:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#29413: Add inputs for pcmanfm and a CVE-2017-8934 patch

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 29413 <at> debbugs.gnu.org.

-- 
29413: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29413
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: brendan.tildesley <at> openmailbox.org
Cc: 29413-done <at> debbugs.gnu.org
Subject: Re: [bug#29413] Add inputs for pcmanfm and a CVE-2017-8934 patch
Date: Thu, 23 Nov 2017 22:56:40 +0100

Hi Brendan,

brendan.tildesley <at> openmailbox.org skribis:

> From 8373ad3d6c23fbff27b4ddf9b5d81f3228ff8654 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
> Date: Fri, 24 Nov 2017 02:22:53 +1100
> Subject: [PATCH 1/2] gnu: pcmanfm: Add missing inputs. Remove comment.
>
> * gnu/packages/lxde.scm
> [inputs]: Add gvfs, for trash and mounting support.
> [propagated-inputs]: Add lxmenu-data, for "Open With..." Applications list.
> Remove comment suggesting to use --sysconfdir. Inspection of the configure
>   script shows that <output>/etc is used for configuration by default anyway,
>   so such a flag is not needed.

I moved the explanations as comments in the code (next to the inputs),
adjusted the commit log for style, and committed.

> From fe1e4cf4c88395cef87a0263acf587672b3132ac Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
> Date: Fri, 24 Nov 2017 02:57:00 +1100
> Subject: [PATCH 2/2] gnu: pcmanfm: Fix CVE-2017-8934.
>
> * gnu/packages/patches/pcmanfm-CVE-2017-8934.patch: New file. This patch was
>   imported from Archlinux.
> * gnu/local.mk (dis_patch_DATA): Add it.
> * gnu/packages/lxde.scm[source]: Use it.

Applied.

Thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: brendan.tildesley <at> openmailbox.org
To: guix-patches <at> gnu.org
Subject: Add inputs for pcmanfm and a CVE-2017-8934 patch
Date: Thu, 23 Nov 2017 16:32:19 -0000

[Message part 4 (text/plain, inline)]

I found that there is a CVE patch for pcmanfm in Arch, so I added it after my inputs patch. I don't know what the code does or if it's needed so only add it if you can judge it is reasonable.

[0001-gnu-pcmanfm-Add-missing-inputs.-Remove-comment.patch (text/x-patch, attachment)]

[0002-gnu-pcmanfm-Fix-CVE-2017-8934.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.