GNU bug report logs - #29413
Add inputs for pcmanfm and a CVE-2017-8934 patch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29413 in the body.
You can then email your comments to 29413 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: brendan.tildesley <at> openmailbox.org
To: guix-patches <at> gnu.org
Subject: Add inputs for pcmanfm and a CVE-2017-8934 patch
Date: Thu, 23 Nov 2017 16:32:19 -0000

[Message part 1 (text/plain, inline)]

I found that there is a CVE patch for pcmanfm in Arch, so I added it after my inputs patch. I don't know what the code does or if it's needed so only add it if you can judge it is reasonable.

[0001-gnu-pcmanfm-Add-missing-inputs.-Remove-comment.patch (text/x-patch, attachment)]

[0002-gnu-pcmanfm-Fix-CVE-2017-8934.patch (text/x-patch, attachment)]

Message #10 received at 29413-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: brendan.tildesley <at> openmailbox.org
Cc: 29413-done <at> debbugs.gnu.org
Subject: Re: [bug#29413] Add inputs for pcmanfm and a CVE-2017-8934 patch
Date: Thu, 23 Nov 2017 22:56:40 +0100

Hi Brendan,

brendan.tildesley <at> openmailbox.org skribis:

> From 8373ad3d6c23fbff27b4ddf9b5d81f3228ff8654 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
> Date: Fri, 24 Nov 2017 02:22:53 +1100
> Subject: [PATCH 1/2] gnu: pcmanfm: Add missing inputs. Remove comment.
>
> * gnu/packages/lxde.scm
> [inputs]: Add gvfs, for trash and mounting support.
> [propagated-inputs]: Add lxmenu-data, for "Open With..." Applications list.
> Remove comment suggesting to use --sysconfdir. Inspection of the configure
>   script shows that <output>/etc is used for configuration by default anyway,
>   so such a flag is not needed.

I moved the explanations as comments in the code (next to the inputs),
adjusted the commit log for style, and committed.

> From fe1e4cf4c88395cef87a0263acf587672b3132ac Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley <at> openmailbox.org>
> Date: Fri, 24 Nov 2017 02:57:00 +1100
> Subject: [PATCH 2/2] gnu: pcmanfm: Fix CVE-2017-8934.
>
> * gnu/packages/patches/pcmanfm-CVE-2017-8934.patch: New file. This patch was
>   imported from Archlinux.
> * gnu/local.mk (dis_patch_DATA): Add it.
> * gnu/packages/lxde.scm[source]: Use it.

Applied.

Thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.