GNU bug report logs - #29303
25.2; vc-git-grep should shell-escape FILES

Previous Next

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 29303 <at> debbugs.gnu.org, gus <at> inodes.org
Subject: bug#29303: 25.2; vc-git-grep should shell-escape FILES
Date: Thu, 16 Nov 2017 16:43:19 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Robert Pluim <rpluim <at> gmail.com>
>> Cc: 29303 <at> debbugs.gnu.org,  gus <at> inodes.org
>> Date: Wed, 15 Nov 2017 21:36:09 +0100
>> 
>> > Ah.  So we lose support of patterns with embedded whitespace in order
>> > to support the aliases?  Is that desirable?
>> 
>> That's a good question. Note that interactively entering patterns with
>> a space is currently a pain, since grep-read-files uses
>> read-file-name-internal, which attempts to do completion if you type
>> <SPC>. So this would presumably only affect people who have changed
>> grep-files-aliases and have patterns with embedded whitespace.
>
> Maybe we should mention this in the doc string (assuming that your
> proposal indeed fixes the original problem).

It fixes my test case, at least. Gus, have you had a chance to try the
second patch?

Thanks

Robert

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.