GNU bug report logs - #29304
26.0.90; Typos in electric.el, with patch

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29304 in the body.
You can then email your comments to 29304 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lele Gaifax <lele <at> metapensiero.it>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; Typos in electric.el, with patch
Date: Wed, 15 Nov 2017 10:21:11 +0100

[Message part 1 (text/plain, inline)]

There are two typos in the definition of the variable
`electric-indent-functions-without-reindent' in lisp/electric.el:

- its docstring mentions a non existing `line-indent-function' instead of the
  correct `indent-line-function';

- its value contains a reference to a non existing `py-indent-line' function,
  that should really be `python-indent-line-function'.

The attached patch fixes both issues.

[0001-Fix-typos-in-electric-indent-functions-without-reind.patch (text/x-diff, inline)]

From c340e5ef63c3bf163eb39b7db5f0c6c34814d97d Mon Sep 17 00:00:00 2001
From: Lele Gaifax <lele <at> metapensiero.it>
Date: Wed, 15 Nov 2017 10:01:45 +0100
Subject: [PATCH 1/2] Fix typos in electric-indent-functions-without-reindent

* lisp/electric.el (electric-indent-functions-without-reindent): Fix
  doc typo, `line-indent-function' -> `indent-line-function'; fix
  python specific indent line function name, `py-indent-line' ->
  `python-indent-line-function'.
---
 lisp/electric.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/electric.el b/lisp/electric.el
index d7929945db..6a08554ed0 100644
--- a/lisp/electric.el
+++ b/lisp/electric.el
@@ -223,11 +223,11 @@ electric-indent-inhibit
 
 (defvar electric-indent-functions-without-reindent
   '(indent-relative indent-to-left-margin indent-relative-maybe
-    py-indent-line coffee-indent-line org-indent-line yaml-indent-line
-    haskell-indentation-indent-line haskell-indent-cycle haskell-simple-indent
-    yaml-indent-line)
+    python-indent-line-function coffee-indent-line org-indent-line
+    yaml-indent-line haskell-indentation-indent-line
+    haskell-indent-cycle haskell-simple-indent yaml-indent-line)
   "List of indent functions that can't reindent.
-If `line-indent-function' is one of those, then `electric-indent-mode' will
+If `indent-line-function' is one of those, then `electric-indent-mode' will
 not try to reindent lines.  It is normally better to make the major
 mode set `electric-indent-inhibit', but this can be used as a workaround.")
 
-- 
2.15.0

[Message part 3 (text/plain, inline)]

-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele <at> metapensiero.it  |                 -- Fortunato Depero, 1929.

Message #8 received at 29304 <at> debbugs.gnu.org (full text, mbox):

From: Lele Gaifax <lele <at> metapensiero.it>
To: 29304 <at> debbugs.gnu.org
Subject: py-indent-line comes from the external python-mode
Date: Wed, 15 Nov 2017 12:58:01 +0100

Further investigation reveals that the external python-mode (that is,
https://gitlab.com/python-mode-devs/python-mode) effectively implements the
`py-indent-line' function, so that was the target.

I guess the attached patch should be ignored.

The docstring typo seems real, though.
-- 
nickname: Lele Gaifax | Quando vivrò di quello che ho pensato ieri
real: Emanuele Gaifas | comincerò ad aver paura di chi mi copia.
lele <at> metapensiero.it  |                 -- Fortunato Depero, 1929.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Röhler <andreas.roehler <at> online.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#29304: py-indent-line comes from the external python-mode
Date: Fri, 17 Nov 2017 09:13:23 +0100

[Message part 1 (text/plain, inline)]

On 15.11.2017 12:58, Lele Gaifax wrote:
> Further investigation reveals that the external python-mode (that is,
> https://gitlab.com/python-mode-devs/python-mode) effectively implements the
> `py-indent-line' function, so that was the target.
>
> I guess the attached patch should be ignored.
>
> The docstring typo seems real, though.

Hi Lele,

could not reproduce the bug.

BTW python-mode.el doesn't provide an electric indent at comma.
At any case it should not get in the way of python.el.
Bug reports are welcome at

https://gitlab.com/python-mode-devs/python-mode/issues

[Message part 2 (text/html, inline)]

Message #16 received at 29304-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lele Gaifax <lele <at> metapensiero.it>
Cc: 29304-done <at> debbugs.gnu.org
Subject: Re: bug#29304: 26.0.90; Typos in electric.el, with patch
Date: Sat, 18 Nov 2017 13:47:26 +0200

> From: Lele Gaifax <lele <at> metapensiero.it>
> Date: Wed, 15 Nov 2017 10:21:11 +0100
> 
> There are two typos in the definition of the variable
> `electric-indent-functions-without-reindent' in lisp/electric.el:
> 
> - its docstring mentions a non existing `line-indent-function' instead of the
>   correct `indent-line-function';

Fixed, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.