GNU bug report logs - #29303
25.2; vc-git-grep should shell-escape FILES

Previous Next

Full log

Message #29 received at 29303 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 29303 <at> debbugs.gnu.org, gus <at> inodes.org
Subject: Re: bug#29303: 25.2; vc-git-grep should shell-escape FILES
Date: Thu, 16 Nov 2017 17:38:20 +0200

> From: Robert Pluim <rpluim <at> gmail.com>
> Cc: 29303 <at> debbugs.gnu.org,  gus <at> inodes.org
> Date: Wed, 15 Nov 2017 21:36:09 +0100
> 
> > Ah.  So we lose support of patterns with embedded whitespace in order
> > to support the aliases?  Is that desirable?
> 
> That's a good question. Note that interactively entering patterns with
> a space is currently a pain, since grep-read-files uses
> read-file-name-internal, which attempts to do completion if you type
> <SPC>. So this would presumably only affect people who have changed
> grep-files-aliases and have patterns with embedded whitespace.

Maybe we should mention this in the doc string (assuming that your
proposal indeed fixes the original problem).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.