GNU bug report logs - #29080
25.3; dired-x does not update `shell-command-history'

Previous Next

Package: emacs;

Reported by: "Matz, Daniel A. (JSC-EG511)" <daniel.a.matz <at> nasa.gov>

Date: Tue, 31 Oct 2017 15:41:01 UTC

Severity: minor

Found in version 25.3

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #17 received at 29080 <at> debbugs.gnu.org (full text, mbox):

From: "Matz, Daniel A. (JSC-EG511)" <daniel.a.matz <at> nasa.gov>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "29080 <at> debbugs.gnu.org" <29080 <at> debbugs.gnu.org>
Subject: Re: bug#29080: 25.3; dired-x does not update `shell-command-history'
Date: Tue, 31 Oct 2017 21:40:36 +0000

> Yes, I think so.  See the comments there.

OK, I see.  When dired-x is loaded, `dired-read-shell-command' calls `dired-guess-shell-command' instead of calling `read-shell-command' directly.  And then`dired-guess-shell-command’ ends up calling `read-shell-command', but specifies a different history variable.  And `dired-do-shell-command' calls `dired-read-shell-command’, but `dired-smart-shell-command’ does not, but instead calls `read-shell-command' directly, using the default history variable.

I ended up just making `dired-shell-command-history' an alias for `shell-command-history’.

Thank you for the help.  We can close this issue.
This bug report was last modified 7 years and 260 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.