GNU bug report logs - #29079
[PATCH] gnu: Add hunspell-en-US.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29079 in the body.
You can then email your comments to 29079 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH] gnu: Add hunspell-en-US.
Date: Tue, 31 Oct 2017 10:47:50 -0400

* gnu/packages/dictionaries.scm (hunspell-en-US): New variable.
---
 gnu/packages/dictionaries.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/dictionaries.scm b/gnu/packages/dictionaries.scm
index 062c29b66..0cc7df394 100644
--- a/gnu/packages/dictionaries.scm
+++ b/gnu/packages/dictionaries.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2014, 2015, 2016 Ludovic Courtès <ludo <at> gnu.org>
 ;;; Copyright © 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2016 Sou Bunnbu <iyzsong <at> gmail.com>
+;;; Copyright © 2017 Kei Kebreau <kkebreau <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -252,3 +253,39 @@ translator powered by Google Translate (default), Bing Translator,
 Yandex.Translate and Apertium.  It gives you easy access to one of these
 translation engines from your terminal.")
     (license public-domain)))
+
+(define-public hunspell-en-US
+  (package
+    (name "hunspell-en-US")
+    (version "2017.01.22")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://launchpad.net/hunspell-en_US/trunk/"
+                                  version "/+download/hunspell-en_US-" version
+                                  ".zip"))
+              (sha256
+               (base32
+                "0svc3m09vz7q37481a0lrf6j2raw65zqg6lazic06s7f1vc6h92i"))))
+    (build-system trivial-build-system)
+    (arguments
+     '(#:builder (begin
+                   (use-modules (guix build utils))
+
+                   (let* ((dict (assoc-ref %build-inputs "source"))
+                          (out (assoc-ref %outputs "out"))
+                          (share (string-append out "/share/hunspell"))
+                          (unzip (string-append
+                                  (assoc-ref %build-inputs "unzip")
+                                  "/bin/unzip")))
+                     (mkdir-p share)
+                     (zero? (system* unzip dict "-d" share))))
+       #:modules ((guix build utils))))
+    (native-inputs
+     `(("source" ,source)
+       ("unzip" ,unzip)))
+    (home-page "http://wordlist.aspell.net/")
+    (synopsis "American English dictionary for use with hunspell")
+    (description
+     "This is an American English dictionary for use with the hunspell spell
+checker.")
+    (license (non-copyleft "file://README_en_US.txt"))))
-- 
2.14.3

Message #8 received at 29079 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 29079 <at> debbugs.gnu.org
Subject: Re: [bug#29079] [PATCH] gnu: Add hunspell-en-US.
Date: Sun, 05 Nov 2017 22:02:21 +0100

Hi Kei,

Kei Kebreau <kkebreau <at> posteo.net> skribis:

> * gnu/packages/dictionaries.scm (hunspell-en-US): New variable.

On the same day I added this one and a couple of other dictionaries:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=085bcca313c3827f7c56e7c345d4606588db9085

The package I committed builds the Hunspell list “from source”.

Let me know whether we should adjust things and what you think of it.

Thanks!

Ludo’.

Message #11 received at 29079 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29079 <at> debbugs.gnu.org
Subject: Re: [bug#29079] [PATCH] gnu: Add hunspell-en-US.
Date: Mon, 06 Nov 2017 22:45:13 -0500

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Kei,
>
> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> * gnu/packages/dictionaries.scm (hunspell-en-US): New variable.
>
> On the same day I added this one and a couple of other dictionaries:
>
>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=085bcca313c3827f7c56e7c345d4606588db9085
>
> The package I committed builds the Hunspell list “from source”.
>
> Let me know whether we should adjust things and what you think of it.
>
> Thanks!
>
> Ludo’.

I definitely like the generality and flexibility of this patch
better. To get the dictionary to work in LibreOffice I had to install
the .dic file as well [0], but once I did that everything seemed to work
as expected.

[0]:
  (mkdir-p myspell)
+ (install-file ,(string-append "speller/" language ".dic")
+               hunspell)
  (install-file ,(string-append "speller/" language ".aff")
                hunspell)

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 29079 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 29079 <at> debbugs.gnu.org
Subject: Re: [bug#29079] [PATCH] gnu: Add hunspell-en-US.
Date: Tue, 07 Nov 2017 09:58:37 +0100

Hi Kei,

Kei Kebreau <kkebreau <at> posteo.net> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Hi Kei,
>>
>> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>>
>>> * gnu/packages/dictionaries.scm (hunspell-en-US): New variable.
>>
>> On the same day I added this one and a couple of other dictionaries:
>>
>>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=085bcca313c3827f7c56e7c345d4606588db9085
>>
>> The package I committed builds the Hunspell list “from source”.
>>
>> Let me know whether we should adjust things and what you think of it.
>>
>> Thanks!
>>
>> Ludo’.
>
> I definitely like the generality and flexibility of this patch
> better. To get the dictionary to work in LibreOffice I had to install
> the .dic file as well [0], but once I did that everything seemed to work
> as expected.
>
> [0]:
>   (mkdir-p myspell)
> + (install-file ,(string-append "speller/" language ".dic")
> +               hunspell)
>   (install-file ,(string-append "speller/" language ".aff")
>                 hunspell)

Nice (I thought Hunspell used exclusively the .aff files.)
OK for this patch!

The hunspell-dict-fr* packages include both .aff and .dic, so that
should be fine.

Thanks,
Ludo’.

Message #17 received at 29079 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29079 <at> debbugs.gnu.org
Subject: Re: [bug#29079] [PATCH] gnu: Add hunspell-en-US.
Date: Thu, 09 Nov 2017 17:53:24 -0500

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hi Kei,
>
> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> ludo <at> gnu.org (Ludovic Courtès) writes:
>>
>>> Hi Kei,
>>>
>>> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>>>
>>>> * gnu/packages/dictionaries.scm (hunspell-en-US): New variable.
>>>
>>> On the same day I added this one and a couple of other dictionaries:
>>>
>>>   https://git.savannah.gnu.org/cgit/guix.git/commit/?id=085bcca313c3827f7c56e7c345d4606588db9085
>>>
>>> The package I committed builds the Hunspell list “from source”.
>>>
>>> Let me know whether we should adjust things and what you think of it.
>>>
>>> Thanks!
>>>
>>> Ludo’.
>>
>> I definitely like the generality and flexibility of this patch
>> better. To get the dictionary to work in LibreOffice I had to install
>> the .dic file as well [0], but once I did that everything seemed to work
>> as expected.
>>
>> [0]:
>>   (mkdir-p myspell)
>> + (install-file ,(string-append "speller/" language ".dic")
>> +               hunspell)
>>   (install-file ,(string-append "speller/" language ".aff")
>>                 hunspell)
>
> Nice (I thought Hunspell used exclusively the .aff files.)
> OK for this patch!
>
> The hunspell-dict-fr* packages include both .aff and .dic, so that
> should be fine.
>
> Thanks,
> Ludo’.

Is this log message okay? I'm not sure how we handle changes to package
template functions.

[0001-gnu-Fix-hunspell-dict-en-dictionary-installation.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 29079 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: 29079 <at> debbugs.gnu.org
Subject: Re: [bug#29079] [PATCH] gnu: Add hunspell-en-US.
Date: Fri, 10 Nov 2017 11:22:51 +0100

Kei Kebreau <kkebreau <at> posteo.net> skribis:

> From c143bad02ebcb7d94ad6e2582b6831c5d107e2a8 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kkebreau <at> posteo.net>
> Date: Thu, 9 Nov 2017 17:49:02 -0500
> Subject: [PATCH] gnu: Fix hunspell-dict-en-* dictionary installation.
>
> * gnu/packages/aspell.scm (aspell-word-list)[arguments]: Install the .dic file
> for all hunspell dictionaries.

Perfect, thanks!

Ludo’.

Message #25 received at 29079-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29079-done <at> debbugs.gnu.org
Subject: Re: [bug#29079] [PATCH] gnu: Add hunspell-en-US.
Date: Fri, 10 Nov 2017 12:00:18 -0500

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Kei Kebreau <kkebreau <at> posteo.net> skribis:
>
>> From c143bad02ebcb7d94ad6e2582b6831c5d107e2a8 Mon Sep 17 00:00:00 2001
>> From: Kei Kebreau <kkebreau <at> posteo.net>
>> Date: Thu, 9 Nov 2017 17:49:02 -0500
>> Subject: [PATCH] gnu: Fix hunspell-dict-en-* dictionary installation.
>>
>> * gnu/packages/aspell.scm (aspell-word-list)[arguments]: Install the .dic file
>> for all hunspell dictionaries.
>
> Perfect, thanks!
>
> Ludo’.

Pushed as d4d7d70912642be18d93c9ce6470f8650097b5e5 to master!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.