GNU bug report logs - #29030
[PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eric Bavier <ericbavier <at> centurylink.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29030: closed ([PATCH] perl-sys-cpu: Mark cpu_type and
 cpu_clock tests as TODO.)
Date: Sun, 29 Oct 2017 04:30:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 28 Oct 2017 18:29:07 -0500
with message-id <20171028182907.60b8629e <at> centurylink.net>
and subject line Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.
has caused the debbugs.gnu.org bug report #29030,
regarding [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29030: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29030
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eric Bavier <bavier <at> cray.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.
Date: Fri, 27 Oct 2017 20:40:12 +0000

[Message part 3 (text/plain, inline)]

Hello Guix,

On my system, perl-sys-cpu's tests fail because of differences in the information available in /proc/cpuinfo.

Debian's patch for this perl module seemed nice: rather than trying to fix the related functions, just concede that the module is mostly used just to read the number of available processors and mark the other tests as "TODO".

This patch replaces the test file with debian's using an origin snippet.

Eric Bavier, Scientific Libraries, Cray Inc.

[guix-perl-sys-cpu-tests.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eric Bavier <ericbavier <at> centurylink.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29030-done <at> debbugs.gnu.org
Subject: Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock
 tests as TODO.
Date: Sat, 28 Oct 2017 18:29:07 -0500

On Sat, 28 Oct 2017 09:51:24 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Hi Eric,
> 
> Eric Bavier <bavier <at> cray.com> skribis:
> 
> > On my system, perl-sys-cpu's tests fail because of differences in the information available in /proc/cpuinfo.
> >
> > Debian's patch for this perl module seemed nice: rather than trying to fix the related functions, just concede that the module is mostly used just to read the number of available processors and mark the other tests as "TODO".  
> 
> [...]
> 
> > +              (snippet
> > +               '(begin
> > +                  ;; Replace test with one that marks cpu_clock and cpu_type
> > +                  ;; as TODO.  Borrowed from Debian.  
> 
> Perhaps make it clear in the comment that we do this because the
> contents of /proc/cpuinfo differ based on different factors.

OK.

> Otherwise LGTM, thanks!

Thanks, pushed in 9de52b56438674c0d0f92be34cebf5f1a38a6bfa.

`~Eric

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.