GNU bug report logs - #29030
[PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29030 in the body.
You can then email your comments to 29030 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> cray.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock tests as TODO.
Date: Fri, 27 Oct 2017 20:40:12 +0000

[Message part 1 (text/plain, inline)]

Hello Guix,

On my system, perl-sys-cpu's tests fail because of differences in the information available in /proc/cpuinfo.

Debian's patch for this perl module seemed nice: rather than trying to fix the related functions, just concede that the module is mostly used just to read the number of available processors and mark the other tests as "TODO".

This patch replaces the test file with debian's using an origin snippet.

Eric Bavier, Scientific Libraries, Cray Inc.

[guix-perl-sys-cpu-tests.patch (text/x-patch, attachment)]

Message #8 received at 29030 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Eric Bavier <bavier <at> cray.com>
Cc: 29030 <at> debbugs.gnu.org
Subject: Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock
 tests as TODO.
Date: Sat, 28 Oct 2017 09:51:24 +0200

Hi Eric,

Eric Bavier <bavier <at> cray.com> skribis:

> On my system, perl-sys-cpu's tests fail because of differences in the information available in /proc/cpuinfo.
>
> Debian's patch for this perl module seemed nice: rather than trying to fix the related functions, just concede that the module is mostly used just to read the number of available processors and mark the other tests as "TODO".

[...]

> +              (snippet
> +               '(begin
> +                  ;; Replace test with one that marks cpu_clock and cpu_type
> +                  ;; as TODO.  Borrowed from Debian.

Perhaps make it clear in the comment that we do this because the
contents of /proc/cpuinfo differ based on different factors.

Otherwise LGTM, thanks!

Ludo’.

Message #13 received at 29030-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <ericbavier <at> centurylink.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 29030-done <at> debbugs.gnu.org
Subject: Re: [bug#29030] [PATCH] perl-sys-cpu: Mark cpu_type and cpu_clock
 tests as TODO.
Date: Sat, 28 Oct 2017 18:29:07 -0500

On Sat, 28 Oct 2017 09:51:24 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Hi Eric,
> 
> Eric Bavier <bavier <at> cray.com> skribis:
> 
> > On my system, perl-sys-cpu's tests fail because of differences in the information available in /proc/cpuinfo.
> >
> > Debian's patch for this perl module seemed nice: rather than trying to fix the related functions, just concede that the module is mostly used just to read the number of available processors and mark the other tests as "TODO".  
> 
> [...]
> 
> > +              (snippet
> > +               '(begin
> > +                  ;; Replace test with one that marks cpu_clock and cpu_type
> > +                  ;; as TODO.  Borrowed from Debian.  
> 
> Perhaps make it clear in the comment that we do this because the
> contents of /proc/cpuinfo differ based on different factors.

OK.

> Otherwise LGTM, thanks!

Thanks, pushed in 9de52b56438674c0d0f92be34cebf5f1a38a6bfa.

`~Eric

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.