GNU bug report logs - #28960
[PATCH] services: Add murmur.

Previous Next

Full log

Message #23 received at 28960 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: nee <nee <at> cock.li>
Cc: 28960 <at> debbugs.gnu.org
Subject: Re: [bug#28960] [PATCH] services: Add murmur.
Date: Tue, 31 Oct 2017 01:02:06 +0100

Heya!

nee <nee <at> cock.li> skribis:

> Am 24.10.2017 um 23:34 schrieb Ludovic Courtès:

[...]

>> If the above macro is good enough, we can add it to (guix records) with
>> a TODO comment.  That would already be better than the other options.
>> 
>
> I added it for now. Personally I don't like having functions with big
> TODOs like this. What would be the solution for thunked delayed fields?
> Force them as they are bound in the let?

The solution would be to do what the accessors do, which is to
transparently force the promise or call the thunk.  Well, for later!

>> This makes me think that it would be good to have a unit test.  Would
>> you like to try writing one now (see the examples in gnu/tests/*.scm),
>> or do you prefer to leave it for later?
> I would like to write some tests, but right now I need to setup my guix
> development environment on a different computer first. On my current
> setup I have 15 gigabytes of free hard drive space and when I run `make
> check-system` it fails with some 'no space left on device' message.

You should probably just run the test you want, as in:

  make check-system TESTS=basic

This is much more reasonable in terms of disk space usage.  See
<https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite.html>.

I’ll take another look soonish and apply the patches if everything’s
alright!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.