GNU bug report logs - #28818
kmacro stepping: void-variable kmacro-step-edit-active

Previous Next

Package: emacs;

Reported by: charles <at> aurox.ch (Charles A. Roelli)

Date: Fri, 13 Oct 2017 18:37:02 UTC

Severity: normal

Merged with 18708

Found in version 24.4.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28818 in the body.
You can then email your comments to 28818 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#28818; Package emacs. (Fri, 13 Oct 2017 18:37:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to charles <at> aurox.ch (Charles A. Roelli):
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 13 Oct 2017 18:37:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: bug-gnu-emacs <at> gnu.org
Subject: kmacro stepping: void-variable kmacro-step-edit-active
Date: Fri, 13 Oct 2017 20:36:16 +0200

From the pretest 26.0.90:

C-x b RET 			> switch to *scratch*
F3 abc F4			> define a simple kmacro
C-x C-k SPC			> edit it
SPC SPC SPC			> run through it

Error in post-command-hook (kmacro-step-edit-post-command):
(void-variable kmacro-step-edit-active)
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28818; Package emacs. (Fri, 13 Oct 2017 19:08:01 GMT) Full text and rfc822 format available.

Message #8 received at 28818 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 28818 <at> debbugs.gnu.org
Subject: Re: bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
Date: Fri, 13 Oct 2017 22:07:34 +0300

> Date: Fri, 13 Oct 2017 20:36:16 +0200
> From: charles <at> aurox.ch (Charles A. Roelli)
> 
> From the pretest 26.0.90:
> 
> C-x b RET 			> switch to *scratch*
> F3 abc F4			> define a simple kmacro
> C-x C-k SPC			> edit it
> SPC SPC SPC			> run through it
> 
> Error in post-command-hook (kmacro-step-edit-post-command):
> (void-variable kmacro-step-edit-active)

Does the below fix this?

diff --git a/lisp/kmacro.el b/lisp/kmacro.el
index 582a58e..4abc571 100644
--- a/lisp/kmacro.el
+++ b/lisp/kmacro.el
@@ -937,7 +937,7 @@ kmacro-edit-lossage
 
 ;;; Single-step editing of keyboard macros
 
-(defvar kmacro-step-edit-active)  	 ;; step-editing active
+(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
 (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
 (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
 (defvar kmacro-step-edit-appending)  	 ;; append to end of macro
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28818; Package emacs. (Sun, 15 Oct 2017 18:42:01 GMT) Full text and rfc822 format available.

Message #11 received at 28818 <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28818 <at> debbugs.gnu.org
Subject: Re: bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
Date: Sun, 15 Oct 2017 20:40:49 +0200

> Date: Fri, 13 Oct 2017 22:07:34 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> > Date: Fri, 13 Oct 2017 20:36:16 +0200
> > From: charles <at> aurox.ch (Charles A. Roelli)
> > 
> > From the pretest 26.0.90:
> > 
> > C-x b RET 			> switch to *scratch*
> > F3 abc F4			> define a simple kmacro
> > C-x C-k SPC			> edit it
> > SPC SPC SPC			> run through it
> > 
> > Error in post-command-hook (kmacro-step-edit-post-command):
> > (void-variable kmacro-step-edit-active)
> 
> Does the below fix this?
> 
> diff --git a/lisp/kmacro.el b/lisp/kmacro.el
> index 582a58e..4abc571 100644
> --- a/lisp/kmacro.el
> +++ b/lisp/kmacro.el
> @@ -937,7 +937,7 @@ kmacro-edit-lossage
>  
>  ;;; Single-step editing of keyboard macros
>  
> -(defvar kmacro-step-edit-active)  	 ;; step-editing active
> +(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
>  (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
>  (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
>  (defvar kmacro-step-edit-appending)  	 ;; append to end of macro

Yes it does.  Thanks.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28818; Package emacs. (Mon, 16 Oct 2017 16:39:01 GMT) Full text and rfc822 format available.

Message #14 received at 28818 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: charles <at> aurox.ch (Charles A. Roelli)
Cc: 28818 <at> debbugs.gnu.org
Subject: Re: bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
Date: Mon, 16 Oct 2017 19:38:28 +0300

merge 18708 28818
close 28818
thanks

> Date: Sun, 15 Oct 2017 20:40:49 +0200
> From: charles <at> aurox.ch (Charles A. Roelli)
> CC: 28818 <at> debbugs.gnu.org
> 
> > Does the below fix this?
> > 
> > diff --git a/lisp/kmacro.el b/lisp/kmacro.el
> > index 582a58e..4abc571 100644
> > --- a/lisp/kmacro.el
> > +++ b/lisp/kmacro.el
> > @@ -937,7 +937,7 @@ kmacro-edit-lossage
> >  
> >  ;;; Single-step editing of keyboard macros
> >  
> > -(defvar kmacro-step-edit-active)  	 ;; step-editing active
> > +(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
> >  (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
> >  (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
> >  (defvar kmacro-step-edit-appending)  	 ;; append to end of macro
> 
> Yes it does.  Thanks.

Thanks, pushed.  As a nice bonus, one more kmacro test now succeeds,
as this bug is a duplicate of bug#18708.
Merged 18708 28818. Request was from Eli Zaretskii <eliz <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 16 Oct 2017 16:40:02 GMT) Full text and rfc822 format available.
bug closed, send any further explanations to 28818 <at> debbugs.gnu.org and charles <at> aurox.ch (Charles A. Roelli) Request was from Eli Zaretskii <eliz <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 16 Oct 2017 16:40:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#28818; Package emacs. (Mon, 16 Oct 2017 18:40:02 GMT) Full text and rfc822 format available.

Message #21 received at 28818 <at> debbugs.gnu.org (full text, mbox):

From: charles <at> aurox.ch (Charles A. Roelli)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28818 <at> debbugs.gnu.org
Subject: Re: bug#28818: kmacro stepping: void-variable kmacro-step-edit-active
Date: Mon, 16 Oct 2017 20:39:39 +0200

> Date: Mon, 16 Oct 2017 19:38:28 +0300
> From: Eli Zaretskii <eliz <at> gnu.org>
> 
> merge 18708 28818
> close 28818
> thanks
> 
> > Date: Sun, 15 Oct 2017 20:40:49 +0200
> > From: charles <at> aurox.ch (Charles A. Roelli)
> > CC: 28818 <at> debbugs.gnu.org
> > 
> > > Does the below fix this?
> > > 
> > > diff --git a/lisp/kmacro.el b/lisp/kmacro.el
> > > index 582a58e..4abc571 100644
> > > --- a/lisp/kmacro.el
> > > +++ b/lisp/kmacro.el
> > > @@ -937,7 +937,7 @@ kmacro-edit-lossage
> > >  
> > >  ;;; Single-step editing of keyboard macros
> > >  
> > > -(defvar kmacro-step-edit-active)  	 ;; step-editing active
> > > +(defvar kmacro-step-edit-active nil)  	 ;; step-editing active
> > >  (defvar kmacro-step-edit-new-macro)  	 ;; storage for new macro
> > >  (defvar kmacro-step-edit-inserting)  	 ;; inserting into macro
> > >  (defvar kmacro-step-edit-appending)  	 ;; append to end of macro
> > 
> > Yes it does.  Thanks.
> 
> Thanks, pushed.  As a nice bonus, one more kmacro test now succeeds,
> as this bug is a duplicate of bug#18708.

Good catch!  Thanks for your help with this.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 14 Nov 2017 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 214 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.