GNU bug report logs - #28756
Substitute download progress bar doesn't reach 100%

Previous Next

Package: guix;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Mon, 9 Oct 2017 03:53:02 UTC

Severity: important

Done: iyzsong <at> member.fsf.org (宋文武)

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: iyzsong <at> member.fsf.org (宋文武)
Cc: 28756 <at> debbugs.gnu.org
Subject: bug#28756: Substitute download progress bar doesn't reach 100%
Date: Tue, 17 Oct 2017 09:16:54 +0200

iyzsong <at> member.fsf.org (宋文武) skribis:

> From 6a3fa69f96fc2e3e074a9275066640ddfee57fd2 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong <at> member.fsf.org>
> Date: Sat, 14 Oct 2017 22:45:55 +0800
> Subject: [PATCH] guix: substitute: Report the last progress in the child
>  process.
>
> Fixes <https://bugs.gnu.org/28756>.
>
> * guix/utils.scm (filtered-port): Close the 'input' port for the current
> process, and close it upon exit in the child process.
> * guix/scripts/substitute.scm (progress-substitution): Display "\n\n" after
> the reporter has finished.

LGTM!

You could commit the utils.scm change separately because it’s a bug-fix
in its own right.

Thank you!

Ludo’.
This bug report was last modified 7 years and 264 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.