GNU bug report logs - #28739
[PATCH 0/5] Update python{,2}-a*

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28739 in the body.
You can then email your comments to 28739 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Cyril Roelandt <tipecaml <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Cyril Roelandt <tipecaml <at> gmail.com>
Subject: [PATCH 0/5] Update python{,2}-a*
Date: Sun,  8 Oct 2017 06:35:40 +0200

Hello,

This patch series provides updates for the python{,2}-a* packages that could
"easily" be upgraded.

I rebuilt all the updated packages, and every package that depends on them, so
this should be pretty safe.

Cyril.
---
Cyril Roelandt (5):
  gnu: python-apispec: Update to 0.25.3.
  gnu: python-arrow: Update to 0.10.0.
  gnu: python-alembic: Update to 0.9.5.
  gnu: python-aniso8601: Update to 1.3.0.
  gnu: Add python2-aniso8601.

 gnu/packages/python.scm | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

-- 
2.14.1

Message #8 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Cyril Roelandt <tipecaml <at> gmail.com>
Cc: 28739 <at> debbugs.gnu.org
Subject: Re: [bug#28739] [PATCH 0/5] Update python{,2}-a*
Date: Mon, 9 Oct 2017 15:22:23 -0400

[Message part 1 (text/plain, inline)]

On Sun, Oct 08, 2017 at 06:35:40AM +0200, Cyril Roelandt wrote:
> Hello,
> 
> This patch series provides updates for the python{,2}-a* packages that could
> "easily" be upgraded.
> 
> I rebuilt all the updated packages, and every package that depends on them, so
> this should be pretty safe.

Great, thanks! I guess you are planning to work through the whole
alphabet?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: Cyril Roelandt <tipecaml <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 28739 <at> debbugs.gnu.org
Subject: Re: [bug#28739] [PATCH 0/5] Update python{,2}-a*
Date: Mon, 9 Oct 2017 21:49:13 +0200

On 10/09/2017 09:22 PM, Leo Famulari wrote:
> Great, thanks! I guess you are planning to work through the whole
> alphabet?

Hehe. So, to give a bit more context: I'm trying to write an updated
version of my Guix backend for tox (the Python virtual environment
manager). One of the issues I have when trying it on real-world projects
is that our Python libraries are a bit outdated.

I wrote a small script that updates a set of python packages, rebuilds
them and also rebuilds the dependent packages. I'll probably publish it
at some point, since it might be useful for other people.

If it's OK with everybody, I'd like to push the simplest patches (those
that only change the version and the hash) without going through a
review first. WDYT?


Cyril.

Message #14 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Cyril Roelandt <tipecaml <at> gmail.com>
Cc: 28739 <at> debbugs.gnu.org
Subject: Re: [bug#28739] [PATCH 0/5] Update python{,2}-a*
Date: Mon, 9 Oct 2017 15:53:19 -0400

[Message part 1 (text/plain, inline)]

On Mon, Oct 09, 2017 at 09:49:13PM +0200, Cyril Roelandt wrote:
> Hehe. So, to give a bit more context: I'm trying to write an updated
> version of my Guix backend for tox (the Python virtual environment
> manager). One of the issues I have when trying it on real-world projects
> is that our Python libraries are a bit outdated.

Yeah, I'm glad you're working on this.

> If it's OK with everybody, I'd like to push the simplest patches (those
> that only change the version and the hash) without going through a
> review first. WDYT?

Sure, I think it's fine. HACKING says:

For patches that just add a new package, and a simple one, it’s OK to
commit [without going through the code review process], if you’re
confident (which means you successfully built it in a chroot setup, and
have done a reasonable copyright and license auditing.)  Likewise for
package upgrades, except upgrades that trigger a lot of rebuilds (for
example, upgrading GnuTLS or GLib.)  We have a mailing list for commit
notifications (guix-commits <at> gnu.org), so people can notice.  Before
pushing your changes, make sure to run ‘git pull --rebase’.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 28739 <at> debbugs.gnu.org, Cyril Roelandt <tipecaml <at> gmail.com>
Subject: Re: [bug#28739] [PATCH 0/5] Update python{,2}-a*
Date: Wed, 11 Oct 2017 21:45:52 +0200

Leo Famulari <leo <at> famulari.name> skribis:

> On Mon, Oct 09, 2017 at 09:49:13PM +0200, Cyril Roelandt wrote:
>> Hehe. So, to give a bit more context: I'm trying to write an updated
>> version of my Guix backend for tox (the Python virtual environment
>> manager). One of the issues I have when trying it on real-world projects
>> is that our Python libraries are a bit outdated.
>
> Yeah, I'm glad you're working on this.
>
>> If it's OK with everybody, I'd like to push the simplest patches (those
>> that only change the version and the hash) without going through a
>> review first. WDYT?
>
> Sure, I think it's fine.

Definitely.  Just make sure to run your script that rebuilds dependents
before pushing, to be on the safe side.

Thanks for working on it!

Ludo’.

Message #20 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: Alan Third <athird <at> googlemail.com>
To: George Plymale II <georgie <at> southernohio.net>
Cc: 28739 <at> debbugs.gnu.org
Subject: Re: bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
Date: Thu, 12 Oct 2017 10:32:12 +0100

[Message part 1 (text/plain, inline)]

My first thought is that you need to install the xcode command line tools.
You do something like:

    xcode-select --install

(I'm using my phone, so I hope this is formatted reasonably.)

On 12 Oct 2017 7:20 a.m., "George Plymale II" <georgie <at> southernohio.net>
wrote:

So I tried compiling Emacs 26 on macOS 10.13. I configured with
`./configure' and everything went fine. However, when I ran `make', the
following error appeared:



/Applications/Xcode.app/Contents/Developer/usr/bin/make -C lib all
  CC       acl_entries.o
  CC       explicit_bzero.o
  CC       fpending.o
  CC       fstatat.o
  CC       getopt.o
  CC       getopt1.o
  CC       lstat.o
  CC       memrchr.o
  CC       mktime.o
  CC       open.o
open.c:75:27: error: unknown type name 'PROMOTED_MODE_T'
      mode = va_arg (arg, PROMOTED_MODE_T);
                          ^
1 error generated.
make[1]: *** [open.o] Error 1
make: *** [lib] Error 2



Upon inspecting this error, I see the following comment above the
offending code:

/* We have to use PROMOTED_MODE_T instead of mode_t, otherwise GCC 4
   creates crashing code when 'mode_t' is smaller than 'int'.  */

I also see the following output regarding `open.c' when I compile with
`make CFLAGS="-v"':



...
  CC       open.o
Apple LLVM version 9.0.0 (clang-900.0.37)
Target: x86_64-apple-darwin17.0.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/
XcodeDefault.xctoolchain/usr/bin
 "/Applications/Xcode.app/Contents/Developer/Toolchains/
XcodeDefault.xctoolchain/usr/bin/clang" -cc1 -triple
x86_64-apple-macosx10.13.0 -Wdeprecated-objc-isa-usage
-Werror=deprecated-objc-isa-usage -emit-obj -mrelax-all -disable-free
-disable-llvm-verifier -discard-value-names -main-file-name open.c
-mrelocation-model pic -pic-level 2 -mthread-model posix -mdisable-fp-elim
-fno-strict-return -masm-verbose -munwind-tables -target-cpu penryn
-target-linker-version 302.3 -v -dwarf-column-info -debugger-tuning=lldb
-coverage-notes-file /Users/my_username/path/to/emacs/lib/open.gcno
-resource-dir /Applications/Xcode.app/Contents/Developer/Toolchains/
XcodeDefault.xctoolchain/usr/lib/clang/9.0.0 -dependency-file deps/open.d
-MT open.o -MP -I . -I ../src -I . -I ./../src -Wno-switch
-Wno-pointer-sign -Wno-string-plus-int -Wno-unknown-attributes
-Wno-initializer-overrides -Wno-tautological-compare
-Wno-tautological-constant-out-of-range-compare -fdebug-compilation-dir
/Users/my_username/path/to/emacs/lib -ferror-limit 19 -fmessage-length 119
-stack-protector 1 -fblocks -fobjc-runtime=macosx-10.13.0
-fencode-extended-block-signature -fmax-type-align=16
-fdiagnostics-show-option -fcolor-diagnostics -o open.o -x c open.c
clang -cc1 version 9.0.0 (clang-900.0.37) default target
x86_64-apple-darwin17.0.0
ignoring duplicate directory "."
ignoring duplicate directory "../src"
#include "..." search starts here:
#include <...> search starts here:
 .
 ../src
 /usr/local/include
 /Applications/Xcode.app/Contents/Developer/Toolchains/
XcodeDefault.xctoolchain/usr/lib/clang/9.0.0/include
 /Applications/Xcode.app/Contents/Developer/Toolchains/
XcodeDefault.xctoolchain/usr/include
 /usr/include
 /System/Library/Frameworks (framework directory)
 /Library/Frameworks (framework directory)
End of search list.
open.c:75:27: error: unknown type name 'PROMOTED_MODE_T'
      mode = va_arg (arg, PROMOTED_MODE_T);
                          ^
1 error generated.
make[1]: *** [open.o] Error 1
make: *** [lib] Error 2



Anyone know how to fix this error? I'd hate to run into something like
this in a non-release-candidate release...

[Message part 2 (text/html, inline)]

Message #23 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: George Plymale II <georgie <at> southernohio.net>
To: Alan Third <athird <at> googlemail.com>
Cc: 28739 <at> debbugs.gnu.org, georgie <at> southernohio.net
Subject: Re: bug#28793: 26.0.90; Compile error with Emacs 26 on macOS 10.13
Date: Thu, 12 Oct 2017 05:53:01 -0400

Thanks for the suggestion, but `xcode-select --install' returns:

xcode-select: error: command line tools are already installed, use "Software Update" to install updates

Message #26 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alan Third <athird <at> googlemail.com>
Cc: 28739 <at> debbugs.gnu.org, George Plymale II <georgie <at> southernohio.net>
Subject: Re: [bug#28739] bug#28793: 26.0.90;
 Compile error with Emacs 26 on macOS 10.13
Date: Thu, 12 Oct 2017 17:28:02 +0200

Alan & George: you are emailing the wrong address.  See
<https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28739>.

Ludo'.

Message #29 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: George Plymale II <georgie <at> southernohio.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: athird <at> googlemail.com, 28739 <at> debbugs.gnu.org
Subject: Re: [bug#28739] bug#28793: 26.0.90;
 Compile error with Emacs 26 on macOS 10.13
Date: Thu, 12 Oct 2017 21:02:16 -0400

> Alan & George: you are emailing the wrong address.  See
> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28739>.

Oops, sorry! I guess Alan accidentally replied to this thread and meant
to reply on `bug-gnu-emacs'. I replied to him and didn't realize we were
on the wrong thread!

Message #34 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Cyril Roelandt <tipecaml <at> gmail.com>
Cc: 28739 <at> debbugs.gnu.org
Subject: Re: [bug#28739] [PATCH 0/5] Update python{,2}-a*
Date: Fri, 13 Oct 2017 08:39:57 +0100

[Message part 1 (text/plain, inline)]

On Sun,  8 Oct 2017 06:35:40 +0200
Cyril Roelandt <tipecaml <at> gmail.com> wrote:

> Hello,
> 
> This patch series provides updates for the python{,2}-a* packages
> that could "easily" be upgraded.
> 
> I rebuilt all the updated packages, and every package that depends on
> them, so this should be pretty safe.
> 
> Cyril.
> ---
> Cyril Roelandt (5):
>   gnu: python-apispec: Update to 0.25.3.
>   gnu: python-arrow: Update to 0.10.0.
>   gnu: python-alembic: Update to 0.9.5.
>   gnu: python-aniso8601: Update to 1.3.0.
>   gnu: Add python2-aniso8601.
> 
>  gnu/packages/python.scm | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)

Hey Cyril, 

When sending a patch series, please first send one message to
guix-patches <at> gnu.org, and then send subsequent patches to
NNN <at> debbugs.gnu.org to make sure they are kept together.

I've now attempted to merge this patch series (bugs 28737, 28738, 28739,
28740, 28741, 28742), and another (bugs 28676, 28677, 28678,
28679, 28680) together, which should mean that they act as one bug. I
think this has worked (although I've got debbugs-gnu in to such a state
now that it will only show me 28738... :( ).

Thanks,

Chris

[Message part 2 (application/pgp-signature, inline)]

Message #37 received at 28739 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: George Plymale II <georgie <at> southernohio.net>
Cc: athird <at> googlemail.com, 28739 <at> debbugs.gnu.org
Subject: Re: [bug#28739] bug#28793: 26.0.90;
 Compile error with Emacs 26 on macOS 10.13
Date: Fri, 13 Oct 2017 10:11:25 +0200

George Plymale II <georgie <at> southernohio.net> skribis:

>> Alan & George: you are emailing the wrong address.  See
>> <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28739>.
>
> Oops, sorry! I guess Alan accidentally replied to this thread and meant
> to reply on `bug-gnu-emacs'. I replied to him and didn't realize we were
> on the wrong thread!

No problem.  Now, you’re welcome to contribute to Guix as well!  ;-)

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.