GNU bug report logs - #28650
[PATCH] gnu: android: Add android-udev-rules package.

Previous Next

Full log

Message #13 received at 28650-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28650-done <at> debbugs.gnu.org
Subject: Re: [bug#28650] [PATCH] gnu: android: Add android-udev-rules package.
Date: Tue, 03 Oct 2017 11:25:24 -0400

ludo <at> gnu.org (Ludovic Courtès) writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> From ea637a7b5adb5f88cb6dc62759f25e36c1ea1acf Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Fri, 29 Sep 2017 09:17:03 -0400
>> Subject: [PATCH] gnu: android: Add android-udev-rules package.
>>
>> * gnu/packages/android.scm (android-udev-rules): Add package.
>
> Committed with this change:
>
> diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
> index bff6a6038..d9be335be 100644
> --- a/gnu/packages/android.scm
> +++ b/gnu/packages/android.scm
> @@ -22,7 +22,6 @@
>  ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>  
>  (define-module (gnu packages android)
> -  #:use-module (guix gexp)
>    #:use-module (guix packages)
>    #:use-module (guix git-download)
>    #:use-module (guix build-system gnu)
> @@ -336,10 +335,12 @@ to a Unix shell that can run commands on the connected device or emulator.")
>      (description "Provides a set of udev rules to allow using Android devices
>  with tools such as @command{adb} and @command{fastboot} without root
>  privileges.  This package is intended to be added as a rule to the
> -@code{udev-service-type} in your @code{operating-system}
> -configuration. Additionally, an @code{adbusers} group must be defined and your
> -user added to it.  @emph{Simply installing this package will @strong{not} have
> -an effect.}")
> +@code{udev-service-type} in your @code{operating-system} configuration.
> +Additionally, an @code{adbusers} group must be defined and your user added to
> +it.
> +
> +@emph{Simply installing this package will not have any effect.}  It is meant
> +to be passed to the @code{udev} service.")
>      (license license:gpl3+)))
>  
>  (define-public git-repo
>
>
> Thanks!
>
> Ludo’.

Thanks for the review!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.