GNU bug report logs - #28650
[PATCH] gnu: android: Add android-udev-rules package.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28650 in the body.
You can then email your comments to 28650 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: android: Add android-udev-rules package.
Date: Fri, 29 Sep 2017 12:09:32 -0400

[Message part 1 (text/plain, inline)]

Hello!

This new package should make it easy for anyone to properly use adb
or the (not yet packaged fastboot) Android command line tools as a
user (rather than root).

It can be used directly in the rules list of the udev service to extend it.

[0001-gnu-android-Add-android-udev-rules-package.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Here's a sample config that demonstrates how it can be used (pay
attention to the definition of the adbusers group).

[config.scm (text/plain, attachment)]

[Message part 5 (text/plain, inline)]

Thank you,

Maxim

Message #10 received at 28650-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 28650-done <at> debbugs.gnu.org
Subject: Re: [bug#28650] [PATCH] gnu: android: Add android-udev-rules package.
Date: Tue, 03 Oct 2017 15:23:57 +0200

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From ea637a7b5adb5f88cb6dc62759f25e36c1ea1acf Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Fri, 29 Sep 2017 09:17:03 -0400
> Subject: [PATCH] gnu: android: Add android-udev-rules package.
>
> * gnu/packages/android.scm (android-udev-rules): Add package.

Committed with this change:

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
index bff6a6038..d9be335be 100644
--- a/gnu/packages/android.scm
+++ b/gnu/packages/android.scm
@@ -22,7 +22,6 @@
 ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
 
 (define-module (gnu packages android)
-  #:use-module (guix gexp)
   #:use-module (guix packages)
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
@@ -336,10 +335,12 @@ to a Unix shell that can run commands on the connected device or emulator.")
     (description "Provides a set of udev rules to allow using Android devices
 with tools such as @command{adb} and @command{fastboot} without root
 privileges.  This package is intended to be added as a rule to the
-@code{udev-service-type} in your @code{operating-system}
-configuration. Additionally, an @code{adbusers} group must be defined and your
-user added to it.  @emph{Simply installing this package will @strong{not} have
-an effect.}")
+@code{udev-service-type} in your @code{operating-system} configuration.
+Additionally, an @code{adbusers} group must be defined and your user added to
+it.
+
+@emph{Simply installing this package will not have any effect.}  It is meant
+to be passed to the @code{udev} service.")
     (license license:gpl3+)))
 
 (define-public git-repo

[Message part 3 (text/plain, inline)]

Thanks!

Ludo’.

Message #13 received at 28650-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28650-done <at> debbugs.gnu.org
Subject: Re: [bug#28650] [PATCH] gnu: android: Add android-udev-rules package.
Date: Tue, 03 Oct 2017 11:25:24 -0400

ludo <at> gnu.org (Ludovic Courtès) writes:

> Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:
>
>> From ea637a7b5adb5f88cb6dc62759f25e36c1ea1acf Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>> Date: Fri, 29 Sep 2017 09:17:03 -0400
>> Subject: [PATCH] gnu: android: Add android-udev-rules package.
>>
>> * gnu/packages/android.scm (android-udev-rules): Add package.
>
> Committed with this change:
>
> diff --git a/gnu/packages/android.scm b/gnu/packages/android.scm
> index bff6a6038..d9be335be 100644
> --- a/gnu/packages/android.scm
> +++ b/gnu/packages/android.scm
> @@ -22,7 +22,6 @@
>  ;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
>  
>  (define-module (gnu packages android)
> -  #:use-module (guix gexp)
>    #:use-module (guix packages)
>    #:use-module (guix git-download)
>    #:use-module (guix build-system gnu)
> @@ -336,10 +335,12 @@ to a Unix shell that can run commands on the connected device or emulator.")
>      (description "Provides a set of udev rules to allow using Android devices
>  with tools such as @command{adb} and @command{fastboot} without root
>  privileges.  This package is intended to be added as a rule to the
> -@code{udev-service-type} in your @code{operating-system}
> -configuration. Additionally, an @code{adbusers} group must be defined and your
> -user added to it.  @emph{Simply installing this package will @strong{not} have
> -an effect.}")
> +@code{udev-service-type} in your @code{operating-system} configuration.
> +Additionally, an @code{adbusers} group must be defined and your user added to
> +it.
> +
> +@emph{Simply installing this package will not have any effect.}  It is meant
> +to be passed to the @code{udev} service.")
>      (license license:gpl3+)))
>  
>  (define-public git-repo
>
>
> Thanks!
>
> Ludo’.

Thanks for the review!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.