GNU bug report logs - #28579
gpa

Previous Next

Full log

Message #11 received at 28579 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 28579 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28579] gpa
Date: Sun, 24 Sep 2017 16:45:56 +0000

[Message part 1 (text/plain, inline)]

Nicolas Goaziou transcribed 1.6K bytes:
> Hello,
> 
> ng0 <ng0 <at> infotropique.org> writes:
> 
> > A GUI for GnuPG.
> >
> > Builds.
> > GUI works, Preferences pick up my $HOME/.gnupg settings.
> > More wasn't tested.
> 
> Thank you. I have some comments about your patch.
> 
> > +(define-public gpa
> > +  (package
> > +    (name "gpa")
> > +    (version "0.9.9")
> 
> version 0.9.10 is out since 2016. Would it make sense to package it instead?

I did only find 0.9.9, but I'll try again. I've catched a cold.

> > +    (source
> > +     (origin
> > +      (method url-fetch)
> > +      (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/"
> > +                          name "-" version ".tar.bz2"))
> 
> Guix lint reports:
> 
>   URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2"

Well I had a mirror first but did not find gpa on it.
I'll try this.

> > +      (sha256
> > +       (base32
> > +        "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("gnupg" ,gnupg)
> > +       ("gpgme" ,gpgme)
> > +       ("libassuan" ,libassuan)
> > +       ("libgpg-error" ,libgpg-error)
> > +       ("gtk+-2" ,gtk+-2)))
> > +    (home-page "https://gnupg.org/software/gpa/index.html")
> > +    (synopsis "GUI for GnuPG")
> > +    (description
> > +     "@defn{GNU Privacy Assistant} (GPA) is a graphical user
> > +interface for the @defn{GNU Privacy Guard} (GnuPG).")
> 
> Guix lint reports an error about invalid Texinfo markup.

Right! It's @dfn{} not @defn{}.

> I'm not sure about what to do to fix it, if there is anything to do at
> all. IMO, @defn is not adequate here.

Why? It is a definition being used.
Although I have to admit it looks unusual compared to the rest of the file.

…
synopsis: GUI for GnuPG
description: "GNU Privacy Assistant" (GPA) is a graphical user interface for the "GNU Privacy Guard" (GnuPG).

> > +    (license license:gpl3)))
> 
> Every ".c" file I checked use "or any later version". I think this
> should be "gpl3+". WDYT?

Okay.

> Regards,
> 
> -- 
> Nicolas Goaziou                                                0x80A93738
> 

Thanks for finding the mistakes. Correction appended.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org

[0001-gnu-Add-gpa.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.