GNU bug report logs - #28579
gpa

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28579 in the body.
You can then email your comments to 28579 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: guix-patches <at> gnu.org
Subject: gpa
Date: Sun, 24 Sep 2017 15:54:52 +0000

[Message part 1 (text/plain, inline)]

A GUI for GnuPG.

Builds.
GUI works, Preferences pick up my $HOME/.gnupg settings.
More wasn't tested.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org

[0001-gnu-Add-gpa.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 28579 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28579 <at> debbugs.gnu.org
Subject: Re: [bug#28579] gpa
Date: Sun, 24 Sep 2017 18:16:02 +0200

Hello,

ng0 <ng0 <at> infotropique.org> writes:

> A GUI for GnuPG.
>
> Builds.
> GUI works, Preferences pick up my $HOME/.gnupg settings.
> More wasn't tested.

Thank you. I have some comments about your patch.

> +(define-public gpa
> +  (package
> +    (name "gpa")
> +    (version "0.9.9")

version 0.9.10 is out since 2016. Would it make sense to package it instead?

> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/"
> +                          name "-" version ".tar.bz2"))

Guix lint reports:

  URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2"

> +      (sha256
> +       (base32
> +        "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gnupg" ,gnupg)
> +       ("gpgme" ,gpgme)
> +       ("libassuan" ,libassuan)
> +       ("libgpg-error" ,libgpg-error)
> +       ("gtk+-2" ,gtk+-2)))
> +    (home-page "https://gnupg.org/software/gpa/index.html")
> +    (synopsis "GUI for GnuPG")
> +    (description
> +     "@defn{GNU Privacy Assistant} (GPA) is a graphical user
> +interface for the @defn{GNU Privacy Guard} (GnuPG).")

Guix lint reports an error about invalid Texinfo markup.

I'm not sure about what to do to fix it, if there is anything to do at
all. IMO, @defn is not adequate here.

> +    (license license:gpl3)))

Every ".c" file I checked use "or any later version". I think this
should be "gpl3+". WDYT?

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

Message #11 received at 28579 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 28579 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28579] gpa
Date: Sun, 24 Sep 2017 16:45:56 +0000

[Message part 1 (text/plain, inline)]

Nicolas Goaziou transcribed 1.6K bytes:
> Hello,
> 
> ng0 <ng0 <at> infotropique.org> writes:
> 
> > A GUI for GnuPG.
> >
> > Builds.
> > GUI works, Preferences pick up my $HOME/.gnupg settings.
> > More wasn't tested.
> 
> Thank you. I have some comments about your patch.
> 
> > +(define-public gpa
> > +  (package
> > +    (name "gpa")
> > +    (version "0.9.9")
> 
> version 0.9.10 is out since 2016. Would it make sense to package it instead?

I did only find 0.9.9, but I'll try again. I've catched a cold.

> > +    (source
> > +     (origin
> > +      (method url-fetch)
> > +      (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/"
> > +                          name "-" version ".tar.bz2"))
> 
> Guix lint reports:
> 
>   URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2"

Well I had a mirror first but did not find gpa on it.
I'll try this.

> > +      (sha256
> > +       (base32
> > +        "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38"))))
> > +    (build-system gnu-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)))
> > +    (inputs
> > +     `(("gnupg" ,gnupg)
> > +       ("gpgme" ,gpgme)
> > +       ("libassuan" ,libassuan)
> > +       ("libgpg-error" ,libgpg-error)
> > +       ("gtk+-2" ,gtk+-2)))
> > +    (home-page "https://gnupg.org/software/gpa/index.html")
> > +    (synopsis "GUI for GnuPG")
> > +    (description
> > +     "@defn{GNU Privacy Assistant} (GPA) is a graphical user
> > +interface for the @defn{GNU Privacy Guard} (GnuPG).")
> 
> Guix lint reports an error about invalid Texinfo markup.

Right! It's @dfn{} not @defn{}.

> I'm not sure about what to do to fix it, if there is anything to do at
> all. IMO, @defn is not adequate here.

Why? It is a definition being used.
Although I have to admit it looks unusual compared to the rest of the file.

…
synopsis: GUI for GnuPG
description: "GNU Privacy Assistant" (GPA) is a graphical user interface for the "GNU Privacy Guard" (GnuPG).

> > +    (license license:gpl3)))
> 
> Every ".c" file I checked use "or any later version". I think this
> should be "gpl3+". WDYT?

Okay.

> Regards,
> 
> -- 
> Nicolas Goaziou                                                0x80A93738
> 

Thanks for finding the mistakes. Correction appended.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org

[0001-gnu-Add-gpa.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 28579 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: ng0 <ng0 <at> infotropique.org>
Cc: 28579 <at> debbugs.gnu.org
Subject: Re: [bug#28579] gpa
Date: Sun, 24 Sep 2017 23:05:52 +0200

ng0 <ng0 <at> infotropique.org> writes:

> Why? It is a definition being used.
> Although I have to admit it looks unusual compared to the rest of the
> file.

It is a package name. By that rule, every package name is a definition,
since you "define" it in the description. It doesn't sound right to put
@dfn in every description, including this one, IMO.

Obviously, I'm nitpicking here.

> Thanks for finding the mistakes. Correction appended.

Thank you.

FWIW, I have no other comment about your patch.

Regards,

Message #17 received at 28579 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 28579 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28579] gpa
Date: Sun, 24 Sep 2017 21:42:00 +0000

[Message part 1 (text/plain, inline)]

Nicolas Goaziou transcribed 0.5K bytes:
> ng0 <ng0 <at> infotropique.org> writes:
> 
> > Why? It is a definition being used.
> > Although I have to admit it looks unusual compared to the rest of the
> > file.
> 
> It is a package name. By that rule, every package name is a definition,
> since you "define" it in the description. It doesn't sound right to put
> @dfn in every description, including this one, IMO.
> 
> Obviously, I'm nitpicking here.

Ok, I agree. If no one commits this in the next 12 hours I'll send
an update removing the @dfn{},

> > Thanks for finding the mistakes. Correction appended.
> 
> Thank you.
> 
> FWIW, I have no other comment about your patch.
> 
> Regards,
> 

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 28579 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 28579 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28579] gpa
Date: Mon, 25 Sep 2017 10:41:27 +0000

[Message part 1 (text/plain, inline)]

ng0 transcribed 1.9K bytes:
> Nicolas Goaziou transcribed 0.5K bytes:
> > ng0 <ng0 <at> infotropique.org> writes:
> > 
> > > Why? It is a definition being used.
> > > Although I have to admit it looks unusual compared to the rest of the
> > > file.
> > 
> > It is a package name. By that rule, every package name is a definition,
> > since you "define" it in the description. It doesn't sound right to put
> > @dfn in every description, including this one, IMO.
> > 
> > Obviously, I'm nitpicking here.
> 
> Ok, I agree. If no one commits this in the next 12 hours I'll send
> an update removing the @dfn{},

Appended is the update, the only change is the description.

> > > Thanks for finding the mistakes. Correction appended.
> > 
> > Thank you.
> > 
> > FWIW, I have no other comment about your patch.
> > 
> > Regards,
> > 
> 
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://krosos.org/dist/keys/
> https://www.infotropique.org https://www.krosos.org



-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[0001-gnu-Add-gpa.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 28579 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 28579 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28579] gpa
Date: Mon, 25 Sep 2017 10:44:17 +0000

[Message part 1 (text/plain, inline)]

Final version.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://krosos.org

[0001-gnu-Add-gpa.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 28579-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: ng0 <ng0 <at> infotropique.org>
Cc: 28579-done <at> debbugs.gnu.org, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: Re: [bug#28579] gpa
Date: Tue, 26 Sep 2017 10:36:03 +0200

[Message part 1 (text/plain, inline)]

ng0 <ng0 <at> infotropique.org> skribis:

> From 1dffbc335e3bad37d990f4a1fddc91f60aa25683 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Sun, 24 Sep 2017 15:52:05 +0000
> Subject: [PATCH] gnu: Add gpa.
>
> * gnu/packages/gnupg.scm (gpa): New variable.

Applied with the cosmetic changes below.

Thanks to the two of you!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/gnupg.scm b/gnu/packages/gnupg.scm
index f9233924b..2e00f9a0c 100644
--- a/gnu/packages/gnupg.scm
+++ b/gnu/packages/gnupg.scm
@@ -827,14 +827,13 @@ them to transform your existing public key into a secret key.")
   (package
     (name "gpa")
     (version "0.9.10")
-    (source
-     (origin
-      (method url-fetch)
-      (uri (string-append "mirror://gnupg/gpa/"
-                          name "-" version ".tar.bz2"))
-      (sha256
-       (base32
-        "09xphbi2456qynwqq5n0yh0zdmdi2ggrj3wk4hsyh5lrzlvcrff3"))))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://gnupg/gpa/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+               (base32
+                "09xphbi2456qynwqq5n0yh0zdmdi2ggrj3wk4hsyh5lrzlvcrff3"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)))
@@ -844,9 +843,10 @@ them to transform your existing public key into a secret key.")
        ("libassuan" ,libassuan)
        ("libgpg-error" ,libgpg-error)
        ("gtk+-2" ,gtk+-2)))
-    (home-page "https://gnupg.org/software/gpa/index.html")
-    (synopsis "GUI for GnuPG")
+    (home-page "https://gnupg.org/software/gpa/")
+    (synopsis "Graphical user interface for GnuPG")
     (description
-     "GPA, the GNU Privacy Assistant, is a graphical user
-interface for GnuPG.")
+     "GPA, the GNU Privacy Assistant, is a graphical user interface for
+@uref{https://gnupg.org, GnuPG}.  It can be used to encrypt, decrypt, and
+sign files, to verify signatures, and to manage the private and public keys.")
     (license license:gpl3+)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.