GNU bug report logs - #28335
[PATCH] vm: Remove redundant conditional in system-disk-image.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Subject: bug#28335: closed (Re: [bug#28335] [PATCH] vm: Remove redundant
 conditional in system-disk-image.)
Date: Mon, 04 Sep 2017 21:37:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#28335: [PATCH] vm: Remove redundant conditional in system-disk-image.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 28335 <at> debbugs.gnu.org.

-- 
28335: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28335
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28335-done <at> debbugs.gnu.org
Subject: Re: [bug#28335] [PATCH] vm: Remove redundant conditional in
 system-disk-image.
Date: Mon, 4 Sep 2017 22:35:57 +0100

[Message part 3 (text/plain, inline)]

On Mon, 04 Sep 2017 14:44:34 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail <at> cbaines.net> skribis:
> 
> > * gnu/system/vm.scm (system-disk-image): Remove redundant
> > conditional for #:file-system-type when calling qemu-image.  
> 
> OK!

Pushed as 4138e782dcfea675ebc2347cbd4ea9abeb9dff36 :)

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] vm: Remove redundant conditional in system-disk-image.
Date: Sun,  3 Sep 2017 11:59:02 +0100

* gnu/system/vm.scm (system-disk-image): Remove redundant conditional for
  #:file-system-type when calling qemu-image.
---
 gnu/system/vm.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
index 4494af003..b3da11876 100644
--- a/gnu/system/vm.scm
+++ b/gnu/system/vm.scm
@@ -403,10 +403,7 @@ to USB sticks meant to be read-only."
                                     (operating-system-bootloader os))
                       #:disk-image-size disk-image-size
                       #:disk-image-format "raw"
-                      #:file-system-type (if (string=? "iso9660"
-                                                       file-system-type)
-                                             "ext4"
-                                             file-system-type)
+                      #:file-system-type file-system-type
                       #:file-system-label root-label
                       #:copy-inputs? #t
                       #:register-closures? #t
-- 
2.14.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.