GNU bug report logs - #28335
[PATCH] vm: Remove redundant conditional in system-disk-image.

Previous Next

Package: guix-patches;

Reported by: Christopher Baines <mail <at> cbaines.net>

Date: Sun, 3 Sep 2017 11:00:02 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28335 in the body.
You can then email your comments to 28335 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#28335; Package guix-patches. (Sun, 03 Sep 2017 11:00:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Christopher Baines <mail <at> cbaines.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 03 Sep 2017 11:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] vm: Remove redundant conditional in system-disk-image.
Date: Sun,  3 Sep 2017 11:59:02 +0100

* gnu/system/vm.scm (system-disk-image): Remove redundant conditional for
  #:file-system-type when calling qemu-image.
---
 gnu/system/vm.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
index 4494af003..b3da11876 100644
--- a/gnu/system/vm.scm
+++ b/gnu/system/vm.scm
@@ -403,10 +403,7 @@ to USB sticks meant to be read-only."
                                     (operating-system-bootloader os))
                       #:disk-image-size disk-image-size
                       #:disk-image-format "raw"
-                      #:file-system-type (if (string=? "iso9660"
-                                                       file-system-type)
-                                             "ext4"
-                                             file-system-type)
+                      #:file-system-type file-system-type
                       #:file-system-label root-label
                       #:copy-inputs? #t
                       #:register-closures? #t
-- 
2.14.1
Information forwarded to guix-patches <at> gnu.org:
bug#28335; Package guix-patches. (Mon, 04 Sep 2017 12:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 28335 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28335 <at> debbugs.gnu.org
Subject: Re: [bug#28335] [PATCH] vm: Remove redundant conditional in
 system-disk-image.
Date: Mon, 04 Sep 2017 14:44:34 +0200

Christopher Baines <mail <at> cbaines.net> skribis:

> * gnu/system/vm.scm (system-disk-image): Remove redundant conditional for
>   #:file-system-type when calling qemu-image.

OK!

Ludo’.
Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Mon, 04 Sep 2017 21:37:02 GMT) Full text and rfc822 format available.
Notification sent to Christopher Baines <mail <at> cbaines.net>:
bug acknowledged by developer. (Mon, 04 Sep 2017 21:37:03 GMT) Full text and rfc822 format available.

Message #13 received at 28335-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28335-done <at> debbugs.gnu.org
Subject: Re: [bug#28335] [PATCH] vm: Remove redundant conditional in
 system-disk-image.
Date: Mon, 4 Sep 2017 22:35:57 +0100

[Message part 1 (text/plain, inline)]
On Mon, 04 Sep 2017 14:44:34 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Christopher Baines <mail <at> cbaines.net> skribis:
> 
> > * gnu/system/vm.scm (system-disk-image): Remove redundant
> > conditional for #:file-system-type when calling qemu-image.  
> 
> OK!

Pushed as 4138e782dcfea675ebc2347cbd4ea9abeb9dff36 :)

[Message part 2 (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 03 Oct 2017 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 263 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.