GNU bug report logs - #28285
Add heimdall

Previous Next

Full log

Message #14 received at 28285 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 28285 <at> debbugs.gnu.org
Subject: Re: [bug#28285] Add heimdall
Date: Sun, 3 Sep 2017 18:53:06 +0200

[Message part 1 (text/plain, inline)]

Le Wed, 30 Aug 2017 21:25:51 +0200,
Marius Bakke <mbakke <at> fastmail.com> a écrit :

> Julien Lepiller <julien <at> lepiller.eu> writes:
> 
> > Hi,
> >
> > this patch adds heimdall, a tool I just used to flash replicant on
> > my smartphone :)  
> 
> Cool!
> 
> > * gnu/packages/android.scm (heimdall): New variable.  
> 
> I agree with Jonathan that 'flashing-tools.scm' is better suited.
> 
> [...]
Ok.

> 
> > +         (replace 'install
> > +           (lambda* (#:key outputs #:allow-other-keys)
> > +             (let ((bin (string-append (assoc-ref outputs "out")
> > "/bin")))
> > +               (mkdir-p bin)
> > +               (copy-file "bin/heimdall" (string-append bin
> > "/heimdall"))
> > +               (copy-file "bin/heimdall-frontend"
> > +                          (string-append bin
> > "/heimdall-frontend"))))))))  
> 
> (copy-file ...) has an unspecified return value[0], so please add a #t
> at the end of this phase for determinism.
Done.

> 
> > +    (inputs
> > +     `(("libusb" ,libusb)
> > +       ("qt" ,qt)  
> 
> Can you try to use the modular qt packages here (qtbase and friends),
> instead of the 'qt' monolith?  The latter is not well maintained and
> will be removed eventually.
only qtbase is needed it seems. Done.

> 
> > +       ("zlib" ,zlib)))
> > +    (home-page "http://glassechidna.com.au/heimdall/")
> > +    (synopsis "Flash firmware onto Samsung mobile devices")
> > +    (description "Heimdall is a tool suite used to flash firmware
> > (aka ROMs) +onto Samsung mobile devices.  Heimdall connects to a
> > mobile device over USB and +interacts with low-level software
> > running on the device, known as Loke.  Loke +and Heimdall
> > communicate via the custom Samsung-developed protocol typically
> > +referred to as the 'Odin 3 protocol'.")  
> 
> `guix lint` should complain about the single quotes, no?  Escaped
> double quotes are okay, though.
It doesn't. I'm not sure what you mean with escaped double quotes. \"
or \\\"?

> 
> LGTM with these cosmetic changes.
I had to change the import of licenses and license field of all
packages because heimdall depends on zlib, which is also a license
name. Should I mention that in the commit message too? Should it be in
a separate commit?

> 
> [0] https://www.gnu.org/software/guile/manual/guile.html#File-System

[0001-gnu-Add-heimdall.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.