GNU bug report logs - #28286
sh-script package has incorrect syntax highlighting when shell type is set to rpm

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28286 in the body.
You can then email your comments to 28286 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andrew Toskin <andrew.toskin <at> gmail.com>
To: GNU Emacs Bug Tracker <bug-gnu-emacs <at> gnu.org>
Subject: sh-script package has incorrect syntax highlighting when shell type
 is set to rpm
Date: Tue, 29 Aug 2017 20:33:42 -0700

[Message part 1 (text/plain, inline)]

* Find an RPM spec file, such as this one for the RPM package of Emacs:
    - https://src.fedoraproject.org/rpms/emacs/raw/master/f/emacs.spec
* Open it in Emacs without user customizations (emacs --quick emacs.spec)
* If necessary, set the shell type (*C-c :*) to rpm
* Notice that even in the %description block starting on line 104,
apostrophes (') are highlighted as if they begin a quoted string.

%description blocks only contain plain text descriptions of the RPM
package, and last until the following %macro; there should be no syntax
highlighting between the two macros. Or if there were, everything inside
the description should all be the same color, until the next %macro starts.

I'm using Emacs 25.2.1, as packaged on Fedora 26 Workstation x86_64. So,
the sh-script 2.0.6 package is built in.

~ Andrew

[Message part 2 (text/html, inline)]

Message #8 received at 28286 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Andrew Toskin <andrew.toskin <at> gmail.com>
Cc: 28286 <at> debbugs.gnu.org
Subject: Re: bug#28286: sh-script package has incorrect syntax highlighting
 when shell type is set to rpm
Date: Wed, 30 Aug 2017 16:30:15 -0400

Andrew Toskin wrote:

> %description blocks only contain plain text descriptions of the RPM
> package, and last until the following %macro; there should be no syntax
> highlighting between the two macros. Or if there were, everything inside
> the description should all be the same color, until the next %macro starts.
>
> I'm using Emacs 25.2.1, as packaged on Fedora 26 Workstation x86_64. So,
> the sh-script 2.0.6 package is built in.

sh-script.el's support for RPM spec files is _extremely_ basic.
There is a dedicated rpm-spec-mode.el distributed separately that you
might prefer.

Message #11 received at 28286 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Toskin <summerfallsaway <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 28286 <at> debbugs.gnu.org
Subject: Re: bug#28286: sh-script package has incorrect syntax highlighting
 when shell type is set to rpm
Date: Wed, 30 Aug 2017 23:51:13 -0700

[Message part 1 (text/plain, inline)]

On Wed, 2017-08-30 at 16:30 -0400, Glenn Morris wrote:

> sh-script.el's support for RPM spec files is _extremely_ basic.
> There is a dedicated rpm-spec-mode.el distributed separately that you
> might prefer.


Sure, but if sh-script mode is going to support the syntax at all, it
should at least be correct, right? When the spec file's %description
section has an odd number of apostrophes, the "string" highlight gobbles up
the rest of the file unless or until it meets another apostrophe somewhere.

[Message part 2 (text/html, inline)]

Message #14 received at 28286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Andrew Toskin <andrew.toskin <at> gmail.com>
Cc: 28286 <at> debbugs.gnu.org
Subject: Re: bug#28286: sh-script package has incorrect syntax highlighting
 when shell type is set to rpm
Date: Sun, 04 Jul 2021 16:48:54 +0200

Andrew Toskin <andrew.toskin <at> gmail.com> writes:

> * Find an RPM spec file, such as this one for the RPM package of Emacs:
>     - https://src.fedoraproject.org/rpms/emacs/raw/master/f/emacs.spec
> * Open it in Emacs without user customizations (emacs --quick emacs.spec)
> * If necessary, set the shell type (C-c :) to rpm 
> * Notice that even in the %description block starting on line 104, apostrophes (')
> are highlighted as if they begin a quoted string.
>
> %description blocks only contain plain text descriptions of the RPM package, and
> last until the following %macro; there should be no syntax highlighting between
> the two macros. Or if there were, everything inside the description should all be
> the same color, until the next %macro starts.

(I'm going through old bug reports that unfortunately got no response at
the time.)

That URL is no longer valid -- does anybody have a .spec file that
demonstrates the problem?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #19 received at 28286 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 28286 <at> debbugs.gnu.org, Andrew Toskin <andrew.toskin <at> gmail.com>
Subject: Re: bug#28286: sh-script package has incorrect syntax highlighting
 when shell type is set to rpm
Date: Mon, 05 Jul 2021 11:46:34 +0200

>>>>> On Sun, 04 Jul 2021 16:48:54 +0200, Lars Ingebrigtsen <larsi <at> gnus.org> said:

    Lars> Andrew Toskin <andrew.toskin <at> gmail.com> writes:
    >> * Find an RPM spec file, such as this one for the RPM package of Emacs:
    >> - https://src.fedoraproject.org/rpms/emacs/raw/master/f/emacs.spec
    >> * Open it in Emacs without user customizations (emacs --quick emacs.spec)
    >> * If necessary, set the shell type (C-c :) to rpm 
    >> * Notice that even in the %description block starting on line 104, apostrophes (')
    >> are highlighted as if they begin a quoted string.
    >> 
    >> %description blocks only contain plain text descriptions of the RPM package, and
    >> last until the following %macro; there should be no syntax highlighting between
    >> the two macros. Or if there were, everything inside the description should all be
    >> the same color, until the next %macro starts.

    Lars> (I'm going through old bug reports that unfortunately got no response at
    Lars> the time.)

    Lars> That URL is no longer valid -- does anybody have a .spec file that
    Lars> demonstrates the problem?

Thereʼs a spec file here, but I canʼt get it to do what the OP
describes:

https://src.fedoraproject.org/rpms/emacs/raw/rawhide/f/emacs.spec

Robert
-- 

Message #22 received at 28286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 28286 <at> debbugs.gnu.org, Andrew Toskin <andrew.toskin <at> gmail.com>
Subject: Re: bug#28286: sh-script package has incorrect syntax highlighting
 when shell type is set to rpm
Date: Mon, 05 Jul 2021 15:30:59 +0200

Robert Pluim <rpluim <at> gmail.com> writes:

> Thereʼs a spec file here, but I canʼt get it to do what the OP
> describes:
>
> https://src.fedoraproject.org/rpms/emacs/raw/rawhide/f/emacs.spec

Thanks.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #25 received at 28286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 28286 <at> debbugs.gnu.org, Andrew Toskin <andrew.toskin <at> gmail.com>
Subject: Re: bug#28286: sh-script package has incorrect syntax highlighting
 when shell type is set to rpm
Date: Mon, 05 Jul 2021 15:32:44 +0200

[Message part 1 (text/plain, inline)]

Robert Pluim <rpluim <at> gmail.com> writes:

> Thereʼs a spec file here, but I canʼt get it to do what the OP
> describes:
>
> https://src.fedoraproject.org/rpms/emacs/raw/rawhide/f/emacs.spec

Thanks; included below for further reference if somebody looks at this
bug report in eight years time.  :-)

I'm not able to reproduce the issue, either -- if I put a ' character
into the %description part, I don't see any adverse effects.  I've tried
this in Emacs 25.1, 26.1 and 28.

So I'm not able to reproduce the problem.  Andrew, are you still seeing
this issue?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

[emacs.spec (application/octet-stream, attachment)]

Message #28 received at 28286 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 28286 <at> debbugs.gnu.org, Andrew Toskin <andrew.toskin <at> gmail.com>
Subject: Re: bug#28286: sh-script package has incorrect syntax highlighting
 when shell type is set to rpm
Date: Wed, 04 Aug 2021 13:29:35 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> So I'm not able to reproduce the problem.  Andrew, are you still seeing
> this issue?

More information was requested, but no response was given within a
month, so I'm closing this bug report.  If the problem still exists,
please respond to this email and we'll reopen the bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.