GNU bug report logs - #28145
[PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28145 <at> debbugs.gnu.org
Subject: [bug#28145] [PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.
Date: Tue, 29 Aug 2017 23:38:02 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> Hi Ludo,
>
> On Tue, 22 Aug 2017 15:07:28 +0200
> ludo <at> gnu.org (Ludovic Courtès) wrote:
>> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>> 
>> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
>> > ISO-9660 superblock anymore.  
>> 
>> Why is it no longer needed?  Otherwise fine with me.  :-)
>
> Because we went ahead and now we just read it from the whole disk on boot (previously, it only accepted superblocks on partitions, remember?).
>
> Previously on master:
>
> - DVD
>   + ISO9660 superblock
>   + partition table
>     + partition
>       + ISO9660 superblock copy <--- GuixSD sees this
>
> Now on master:
>
> - DVD
>   + ISO9660 superblock <--- GuixSD sees this
>   + partition table
>     + partition
>       + ISO9660 superblock copy <--- what's this for now?
>
> With the patch:
>
> - DVD
>   + ISO9660 superblock <--- GuixSD sees this
>   + partition table
>     + partition

Thanks for the explanation, got it now.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.