GNU bug report logs - #28145
[PATCH] build: Do not store two copies of the ISO-9660 superblock anymore.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28145 in the body.
You can then email your comments to 28145 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] build: Do not store two copies of the ISO-9660 superblock
 anymore.
Date: Sat, 19 Aug 2017 04:46:56 +0200

* gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
ISO-9660 superblock anymore.
---
 gnu/build/vm.scm | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm
index 727494ad9..409320b1a 100644
--- a/gnu/build/vm.scm
+++ b/gnu/build/vm.scm
@@ -379,19 +379,6 @@ GRUB configuration and OS-DRV as the stuff in it."
                             "var=/tmp/root/var"
                             "run=/tmp/root/run"
                             "--"
-                            ;; Store two copies of the headers.
-                            ;; The resulting ISO-9660 image has a DOS MBR and
-                            ;; one protective partition (with type 0xCD).
-                            ;; Because GuixSD only uses actual partitions
-                            ;; rather than what /proc/partitions returns, work
-                            ;; around it by storing the primary volume
-                            ;; descriptor twice, once where it should be and
-                            ;; once in the partition.
-                            ;; Allegedly, otherwise, many other GNU tools
-                            ;; (automounters etc) would also be confused by
-                            ;; the extra partition so it makes sense to
-                            ;; store two copies in any case.
-                            "-boot_image" "any" "partition_offset=16"
                             "-volid" ,(string-upcase volume-id)
                             ,@(if volume-uuid
                                   `("-volume_date" "uuid"

Message #8 received at 28145 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28145 <at> debbugs.gnu.org
Subject: Re: [bug#28145] [PATCH] build: Do not store two copies of the
 ISO-9660 superblock anymore.
Date: Tue, 22 Aug 2017 15:07:28 +0200

Hello Danny,

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
> ISO-9660 superblock anymore.

Why is it no longer needed?  Otherwise fine with me.  :-)

Ludo’.

Message #11 received at 28145 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 28145 <at> debbugs.gnu.org
Subject: Re: [bug#28145] [PATCH] build: Do not store two copies of the
 ISO-9660 superblock anymore.
Date: Tue, 29 Aug 2017 07:49:02 +0200

Hi Ludo,

On Tue, 22 Aug 2017 15:07:28 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:
> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
> 
> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
> > ISO-9660 superblock anymore.  
> 
> Why is it no longer needed?  Otherwise fine with me.  :-)

Because we went ahead and now we just read it from the whole disk on boot (previously, it only accepted superblocks on partitions, remember?).

Previously on master:

- DVD
  + ISO9660 superblock
  + partition table
    + partition
      + ISO9660 superblock copy <--- GuixSD sees this

Now on master:

- DVD
  + ISO9660 superblock <--- GuixSD sees this
  + partition table
    + partition
      + ISO9660 superblock copy <--- what's this for now?

With the patch:

- DVD
  + ISO9660 superblock <--- GuixSD sees this
  + partition table
    + partition

Message #14 received at 28145 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28145 <at> debbugs.gnu.org
Subject: Re: [bug#28145] [PATCH] build: Do not store two copies of the
 ISO-9660 superblock anymore.
Date: Tue, 29 Aug 2017 23:38:02 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> skribis:

> Hi Ludo,
>
> On Tue, 22 Aug 2017 15:07:28 +0200
> ludo <at> gnu.org (Ludovic Courtès) wrote:
>> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>> 
>> > * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
>> > ISO-9660 superblock anymore.  
>> 
>> Why is it no longer needed?  Otherwise fine with me.  :-)
>
> Because we went ahead and now we just read it from the whole disk on boot (previously, it only accepted superblocks on partitions, remember?).
>
> Previously on master:
>
> - DVD
>   + ISO9660 superblock
>   + partition table
>     + partition
>       + ISO9660 superblock copy <--- GuixSD sees this
>
> Now on master:
>
> - DVD
>   + ISO9660 superblock <--- GuixSD sees this
>   + partition table
>     + partition
>       + ISO9660 superblock copy <--- what's this for now?
>
> With the patch:
>
> - DVD
>   + ISO9660 superblock <--- GuixSD sees this
>   + partition table
>     + partition

Thanks for the explanation, got it now.

Ludo’.

Message #17 received at 28145 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28145 <at> debbugs.gnu.org
Subject: Re: [bug#28145] [PATCH] build: Do not store two copies of the
 ISO-9660 superblock anymore.
Date: Tue, 19 Sep 2017 23:29:49 +0200

Hi Danny,

Just a reminder that this patch hasn’t been applied.  TIA!  :-)

Ludo’.

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Hello Danny,
>
> Danny Milosavljevic <dannym <at> scratchpost.org> skribis:
>
>> * gnu/build/vm.scm (make-iso9660-image): Do not store two copies of the
>> ISO-9660 superblock anymore.
>
> Why is it no longer needed?  Otherwise fine with me.  :-)
>
> Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.