GNU bug report logs - #27905
changes for openmpi

Previous Next

Full log

View this message in rfc822 format

From: Dave Love <fx <at> gnu.org>
To: Ludovic Courtès <ludovic.courtes <at> inria.fr>
Cc: 27905 <at> debbugs.gnu.org
Subject: [bug#27905] changes for openmpi
Date: Thu, 07 Sep 2017 17:14:43 +0100

Ludovic Courtès <ludovic.courtes <at> inria.fr> writes:

>>> Also, I assume that this is functionally equivalent to Open MPI’s
>>> built-in Valgrind support, is it?
>>
>> This is probably moot.  It isn't entirely equivalent but, more
>> importantly, the builtin support apparently doesn't have the performance
>> hit which was documented; I haven't checked experimentally.  See this
>> thread, though not all my questions were answered:
>> <https://www.mail-archive.com/users <at> lists.open-mpi.org//msg31459.html>.
>>
>> The wrapper library may still be relevant for mpich-y MPIs, if they get
>> used -- I don't know.
>
> OK.
>
> So to me that means we can apply the patch below and be done with it.
> Fine with you?

No, I now think it shouldn't be changed, since the valgrind integration
is supposed not to impose a significant speed penalty, and I can remove
valgrind from the closure simply.  I'll send a new patch later.

> Thanks,
> Ludo’.
>
>
> diff --git a/gnu/packages/mpi.scm b/gnu/packages/mpi.scm
> index 93157e269..ded9d4fda 100644
> --- a/gnu/packages/mpi.scm
> +++ b/gnu/packages/mpi.scm
> @@ -36,8 +36,7 @@
>    #:use-module (gnu packages xml)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages ncurses)
> -  #:use-module (gnu packages pkg-config)
> -  #:use-module (gnu packages valgrind))
> +  #:use-module (gnu packages pkg-config))
>  
>  (define-public hwloc
>    (package
> @@ -126,8 +125,7 @@ bind processes, and much more.")
>       `(("hwloc" ,hwloc "lib")
>         ("gfortran" ,gfortran)
>         ("libfabric" ,libfabric)
> -       ("rdma-core" ,rdma-core)
> -       ("valgrind" ,valgrind)))
> +       ("rdma-core" ,rdma-core)))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("perl" ,perl)))
> @@ -142,8 +140,6 @@ bind processes, and much more.")
>                             ;; it reduces the closure size considerably.
>                             "--disable-vt"
>  
> -                           ,(string-append "--with-valgrind="
> -                                           (assoc-ref %build-inputs "valgrind"))
>                             ,(string-append "--with-hwloc="
>                                             (assoc-ref %build-inputs "hwloc")))
>         #:phases (modify-phases %standard-phases

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.