GNU bug report logs - #27893
[PATCH] gnu: julia: Work around some test failures related to libgit2.

Previous Next

Full log

Message #19 received at 27893-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 27893-done <at> debbugs.gnu.org
Subject: Re: [bug#27893] [PATCH] gnu: julia: Work around some test failures
 related to libgit2.
Date: Wed, 07 Mar 2018 15:03:14 +0100

Hello,

ludo <at> gnu.org (Ludovic Courtès) skribis:

> Leo Famulari <leo <at> famulari.name> skribis:
>
>> * gnu/packages/version-control.scm (libgit2-0.25): New variable.
>> * gnu/packages/julia.scm (julia)[inputs]: Replace LIBGIT2 with LIBGIT2-0.25.
>> * gnu/packages/patches/libgit2-use-after-free.patch: New file.
>> * gnu/local.mk (dist_patch_DATA): Add it.
>
> Sorry for not noticing the breakage!  I wonder if it would be
> easier/safer to fix Julia than to keep the old libgit2.
>
> Does this upstream commit fix the failures that you saw?
>
> commit 782460f9bab4af35097c13c4dbab61cb263490b9
> Author: Milan Bouchet-Valat <nalimilan <at> club.fr>
> Date:   Tue Jul 11 10:02:32 2017 +0200
>
>     Fix libgit2 test failure with system libgit2 and OpenSSL (#22722)
>     
>     The first letter of the error message is in lowercase in some systems,
>     notably Fedora Rawhide with libgit2 0.26 and OpenSSL 1.1.0f.
>
> diff --git a/test/libgit2.jl b/test/libgit2.jl
> index d7e32d21a9..f5104e9ec7 100644
> --- a/test/libgit2.jl
> +++ b/test/libgit2.jl
> @@ -1905,7 +1905,8 @@ mktempdir() do dir
>                          deserialize(f)
>                      end
>                      @test err.code == LibGit2.Error.ECERTIFICATE
> -                    @test startswith(err.msg, "The SSL certificate is invalid")
> +                    @test startswith(lowercase(err.msg),
> +                                     lowercase("The SSL certificate is invalid"))

As it turns out, I later fixed this in a different way, having forgotten
about this discussion, in commit d40b5684c533e0188ffa213b20f2d3c88406d895.

Case closed!

Note that there are other issues discussed at
<https://bugs.gnu.org/30282>.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.