GNU bug report logs - #27892
[PATCH] gnu: libgit2: Enable SHA-1 collision detection.

Previous Next

Package: guix-patches;

Reported by: Leo Famulari <leo <at> famulari.name>

Date: Mon, 31 Jul 2017 23:02:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27892 in the body.
You can then email your comments to 27892 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#27892; Package guix-patches. (Mon, 31 Jul 2017 23:02:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo Famulari <leo <at> famulari.name>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 31 Jul 2017 23:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libgit2: Enable SHA-1 collision detection.
Date: Mon, 31 Jul 2017 19:01:18 -0400

* gnu/packages/version-control.scm (libgit2)[arguments]: Enable '-DUSE_SHA1DC'
in #:configure-flags.
---
 gnu/packages/version-control.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index bc4242fc1..9667b2f3e 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -347,7 +347,8 @@ everything from small to very large projects with speed and efficiency.")
     (build-system cmake-build-system)
     (outputs '("out" "debug"))
     (arguments
-     `(#:phases
+     `(#:configure-flags '("-DUSE_SHA1DC=ON") ; SHA-1 collision detection
+       #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'fix-hardcoded-paths
            (lambda _
-- 
2.13.3
Information forwarded to guix-patches <at> gnu.org:
bug#27892; Package guix-patches. (Tue, 01 Aug 2017 00:43:02 GMT) Full text and rfc822 format available.

Message #8 received at 27892 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, 27892 <at> debbugs.gnu.org
Subject: Re: [bug#27892] [PATCH] gnu: libgit2: Enable SHA-1 collision
 detection.
Date: Tue, 01 Aug 2017 02:42:09 +0200

[Message part 1 (text/plain, inline)]
Leo Famulari <leo <at> famulari.name> writes:

> * gnu/packages/version-control.scm (libgit2)[arguments]: Enable '-DUSE_SHA1DC'
> in #:configure-flags.

LGTM, thanks!

[signature.asc (application/pgp-signature, inline)]
bug closed, send any further explanations to 27892 <at> debbugs.gnu.org and Leo Famulari <leo <at> famulari.name> Request was from Efraim Flashner <efraim <at> flashner.co.il> to control <at> debbugs.gnu.org. (Tue, 01 Aug 2017 15:15:02 GMT) Full text and rfc822 format available.
Information forwarded to guix-patches <at> gnu.org:
bug#27892; Package guix-patches. (Tue, 01 Aug 2017 15:29:01 GMT) Full text and rfc822 format available.

Message #13 received at 27892-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27892-done <at> debbugs.gnu.org
Subject: Re: [bug#27892] [PATCH] gnu: libgit2: Enable SHA-1 collision
 detection.
Date: Tue, 1 Aug 2017 11:28:40 -0400

[Message part 1 (text/plain, inline)]
On Tue, Aug 01, 2017 at 02:42:09AM +0200, Marius Bakke wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> 
> > * gnu/packages/version-control.scm (libgit2)[arguments]: Enable '-DUSE_SHA1DC'
> > in #:configure-flags.
> 
> LGTM, thanks!

Thanks, pushed!

[signature.asc (application/pgp-signature, inline)]
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 30 Aug 2017 11:24:05 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 295 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.