GNU bug report logs - #27890
26.0.50; describe-font does not use Help buffer history

Previous Next

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Alex <agrambot <at> gmail.com>
Cc: 27890 <at> debbugs.gnu.org
Subject: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Sun, 06 Aug 2017 07:43:08 -0400

Alex <agrambot <at> gmail.com> writes:

> npostavs <at> users.sourceforge.net writes:
>
>> Looks fine, personally I wouldn't bother introducing that local
>> variable.
>
> I introduced that variable because the procedure conditionally sets
> fontname if it's an empty sequence. As it stands, the procedure would
> error without capturing that variable ahead of time due to `length' being
> called on a font object.

Oops, right.  I skimmed too quickly because your patch looked so simple.

> I figured this was the simplest way around that problem. Do you have an
> easier way in mind? I could perhaps change the setq line to instead set
> fontname to (face-attribute 'default :family), which would allow for
> removing the local variable safely.

No, let's not get bogged down in micro-optimization and just go with
what you had originally.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.