GNU bug report logs - #27890
26.0.50; describe-font does not use Help buffer history

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27890 in the body.
You can then email your comments to 27890 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; describe-font does not use Help buffer history
Date: Mon, 31 Jul 2017 15:25:16 -0600

describe-font does not add to the *Help* buffer's history. The [Back]
button does appear when there is a non-empty history, but going back and
then forward does not restore the font description.

Message #8 received at 27890 <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: 27890 <at> debbugs.gnu.org
Subject: Re: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Sat, 05 Aug 2017 17:05:29 -0600

[Message part 1 (text/plain, inline)]

Alex <agrambot <at> gmail.com> writes:

> describe-font does not add to the *Help* buffer's history. The [Back]
> button does appear when there is a non-empty history, but going back and
> then forward does not restore the font description.

Here's a patch for it.

[0001-Use-help-mode-xrefs-in-describe-font.patch (text/x-diff, attachment)]

Message #11 received at 27890 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Alex <agrambot <at> gmail.com>
Cc: 27890 <at> debbugs.gnu.org
Subject: Re: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Sat, 05 Aug 2017 20:21:37 -0400

tags 27890 + patch
quit

Alex <agrambot <at> gmail.com> writes:

> Alex <agrambot <at> gmail.com> writes:
>
>> describe-font does not add to the *Help* buffer's history. The [Back]
>> button does appear when there is a non-empty history, but going back and
>> then forward does not restore the font description.
>
> Here's a patch for it.
>
> +  (let ((xref-item (list #'describe-font fontname))
[...]
> +      (help-setup-xref xref-item (called-interactively-p 'interactive))

Looks fine, personally I wouldn't bother introducing that local
variable.

Message #16 received at 27890 <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 27890 <at> debbugs.gnu.org
Subject: Re: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Sat, 05 Aug 2017 20:01:33 -0600

npostavs <at> users.sourceforge.net writes:

> tags 27890 + patch
> quit
>
> Alex <agrambot <at> gmail.com> writes:
>
>> Alex <agrambot <at> gmail.com> writes:
>>
>>> describe-font does not add to the *Help* buffer's history. The [Back]
>>> button does appear when there is a non-empty history, but going back and
>>> then forward does not restore the font description.
>>
>> Here's a patch for it.
>>
>> +  (let ((xref-item (list #'describe-font fontname))
> [...]
>> +      (help-setup-xref xref-item (called-interactively-p 'interactive))
>
> Looks fine, personally I wouldn't bother introducing that local
> variable.

I introduced that variable because the procedure conditionally sets
fontname if it's an empty sequence. As it stands, the procedure would
error without capturing that variable ahead of time due to `length' being
called on a font object.

I figured this was the simplest way around that problem. Do you have an
easier way in mind? I could perhaps change the setq line to instead set
fontname to (face-attribute 'default :family), which would allow for
removing the local variable safely.

Message #19 received at 27890 <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 27890 <at> debbugs.gnu.org
Subject: Re: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Sat, 05 Aug 2017 21:24:03 -0600

Alex <agrambot <at> gmail.com> writes:

> npostavs <at> users.sourceforge.net writes:
>
>> tags 27890 + patch
>> quit
>>
>> Alex <agrambot <at> gmail.com> writes:
>>
>>> Here's a patch for it.
>>>
>>> +  (let ((xref-item (list #'describe-font fontname))
>> [...]
>>> +      (help-setup-xref xref-item (called-interactively-p 'interactive))
>>
>> Looks fine, personally I wouldn't bother introducing that local
>> variable.
>
> I introduced that variable because the procedure conditionally sets
> fontname if it's an empty sequence. As it stands, the procedure would
> error without capturing that variable ahead of time due to `length' being
> called on a font object.
>
> I figured this was the simplest way around that problem. Do you have an
> easier way in mind? I could perhaps change the setq line to instead set
> fontname to (face-attribute 'default :family), which would allow for
> removing the local variable safely.

I made a patch that does this, but it doesn't behave exactly the same.
(font-info (face-attribute 'default :family)) for me returns a font with
size/height 16/19, but (font-info (face-attribute 'default :font))
returns a font with size/height 15/18. I've tried this with multiple
fonts, and it happens with each one.

This seems like a bug.

Message #22 received at 27890 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Alex <agrambot <at> gmail.com>
Cc: 27890 <at> debbugs.gnu.org
Subject: Re: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Sun, 06 Aug 2017 07:43:08 -0400

Alex <agrambot <at> gmail.com> writes:

> npostavs <at> users.sourceforge.net writes:
>
>> Looks fine, personally I wouldn't bother introducing that local
>> variable.
>
> I introduced that variable because the procedure conditionally sets
> fontname if it's an empty sequence. As it stands, the procedure would
> error without capturing that variable ahead of time due to `length' being
> called on a font object.

Oops, right.  I skimmed too quickly because your patch looked so simple.

> I figured this was the simplest way around that problem. Do you have an
> easier way in mind? I could perhaps change the setq line to instead set
> fontname to (face-attribute 'default :family), which would allow for
> removing the local variable safely.

No, let's not get bogged down in micro-optimization and just go with
what you had originally.

Message #25 received at 27890 <at> debbugs.gnu.org (full text, mbox):

From: Alex <agrambot <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 27890 <at> debbugs.gnu.org
Subject: Re: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Mon, 07 Aug 2017 15:19:45 -0600

npostavs <at> users.sourceforge.net writes:

> No, let's not get bogged down in micro-optimization and just go with
> what you had originally.

Sounds good. Would you please commit it for me at an appropriate time?

Thanks.

Message #28 received at 27890 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Alex <agrambot <at> gmail.com>
Cc: 27890 <at> debbugs.gnu.org
Subject: Re: bug#27890: 26.0.50; describe-font does not use Help buffer history
Date: Tue, 08 Aug 2017 19:58:50 -0400

tags 27890 fixed
close 27890 26.1
quit

Alex <agrambot <at> gmail.com> writes:

> npostavs <at> users.sourceforge.net writes:
>
>> No, let's not get bogged down in micro-optimization and just go with
>> what you had originally.
>
> Sounds good. Would you please commit it for me at an appropriate time?

Pushed to master.

[1: 9723782161]: 2017-08-08 19:57:24 -0400
  Use help-mode xrefs in describe-font
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9723782161f9b1ea6c3ce883acdc1090172b01c3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.