GNU bug report logs - #27663
[PATCH] database: Fix typo.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#27663: closed ([PATCH] database: Fix typo.)
Date: Wed, 12 Jul 2017 17:06:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 12 Jul 2017 19:05:17 +0200
with message-id <87d1957fhu.fsf <at> gmail.com>
and subject line Re: [bug#27663] [PATCH] database: Fix typo.
has caused the debbugs.gnu.org bug report #27663,
regarding [PATCH] database: Fix typo.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
27663: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27663
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] database: Fix typo.
Date: Wed, 12 Jul 2017 10:11:11 +0200

* src/cuirass/database.scm (db-get-stamp, db-add-stamp): Replace #:id
  by #:name. There is no #:id in specifications. Plus, the primary key
  of Specifications is #:name.
---
 src/cuirass/database.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm
index 1ced411..804b8c2 100644
--- a/src/cuirass/database.scm
+++ b/src/cuirass/database.scm
@@ -195,7 +195,7 @@ INSERT INTO Builds (derivation, evaluation, log, output)\
 (define (db-get-stamp db spec)
   "Return a stamp corresponding to specification SPEC in database DB."
   (let ((res (sqlite-exec db "SELECT * FROM Stamps WHERE specification='~A';"
-                          (assq-ref spec #:id))))
+                          (assq-ref spec #:name))))
     (match res
       (() "")
       ((#(spec commit)) commit))))
@@ -205,9 +205,9 @@ INSERT INTO Builds (derivation, evaluation, log, output)\
   (if (string-null? (db-get-stamp db spec))
       (sqlite-exec db "\
 INSERT INTO Stamps (specification, stamp) VALUES ('~A', '~A');"
-                   (assq-ref spec #:id)
+                   (assq-ref spec #:name)
                    commit)
       (sqlite-exec db "\
 UPDATE Stamps SET stamp='~A' WHERE specification='~A';"
                    commit
-                   (assq-ref spec #:id))))
+                   (assq-ref spec #:name))))
-- 
2.13.1

[Message part 3 (message/rfc822, inline)]

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27663-done <at> debbugs.gnu.org
Subject: Re: [bug#27663] [PATCH] database: Fix typo.
Date: Wed, 12 Jul 2017 19:05:17 +0200

Pushed thanks !

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.