GNU bug report logs - #27663
[PATCH] database: Fix typo.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27663 in the body.
You can then email your comments to 27663 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Mathieu Othacehe <m.othacehe <at> gmail.com>
Subject: [PATCH] database: Fix typo.
Date: Wed, 12 Jul 2017 10:11:11 +0200

* src/cuirass/database.scm (db-get-stamp, db-add-stamp): Replace #:id
  by #:name. There is no #:id in specifications. Plus, the primary key
  of Specifications is #:name.
---
 src/cuirass/database.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm
index 1ced411..804b8c2 100644
--- a/src/cuirass/database.scm
+++ b/src/cuirass/database.scm
@@ -195,7 +195,7 @@ INSERT INTO Builds (derivation, evaluation, log, output)\
 (define (db-get-stamp db spec)
   "Return a stamp corresponding to specification SPEC in database DB."
   (let ((res (sqlite-exec db "SELECT * FROM Stamps WHERE specification='~A';"
-                          (assq-ref spec #:id))))
+                          (assq-ref spec #:name))))
     (match res
       (() "")
       ((#(spec commit)) commit))))
@@ -205,9 +205,9 @@ INSERT INTO Builds (derivation, evaluation, log, output)\
   (if (string-null? (db-get-stamp db spec))
       (sqlite-exec db "\
 INSERT INTO Stamps (specification, stamp) VALUES ('~A', '~A');"
-                   (assq-ref spec #:id)
+                   (assq-ref spec #:name)
                    commit)
       (sqlite-exec db "\
 UPDATE Stamps SET stamp='~A' WHERE specification='~A';"
                    commit
-                   (assq-ref spec #:id))))
+                   (assq-ref spec #:name))))
-- 
2.13.1

Message #8 received at 27663 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 27663 <at> debbugs.gnu.org
Subject: Re: [bug#27663] [PATCH] database: Fix typo.
Date: Wed, 12 Jul 2017 10:47:51 +0200

LGTM!

Message #11 received at 27663 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Mathieu Othacehe <m.othacehe <at> gmail.com>
Cc: 27663 <at> debbugs.gnu.org
Subject: Re: [bug#27663] [PATCH] database: Fix typo.
Date: Wed, 12 Jul 2017 14:25:48 +0200

Mathieu Othacehe <m.othacehe <at> gmail.com> skribis:

> * src/cuirass/database.scm (db-get-stamp, db-add-stamp): Replace #:id
>   by #:name. There is no #:id in specifications. Plus, the primary key
>   of Specifications is #:name.

Good catch, go for it!

BTW, while you’re at it ;-), would you mind opening a ticket on Savannah
asking them to send us commit notifications for Cuirass to guix-commits?

Thanks,
Ludo’.

Message #14 received at 27663 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27663 <at> debbugs.gnu.org
Subject: Re: [bug#27663] [PATCH] database: Fix typo.
Date: Wed, 12 Jul 2017 16:12:49 +0200

> Good catch, go for it!

Thanks !

> BTW, while you’re at it ;-), would you mind opening a ticket on Savannah
> asking them to send us commit notifications for Cuirass to guix-commits?

Done :) 

Mathieu

Message #19 received at 27663-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <m.othacehe <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27663-done <at> debbugs.gnu.org
Subject: Re: [bug#27663] [PATCH] database: Fix typo.
Date: Wed, 12 Jul 2017 19:05:17 +0200

Pushed thanks !

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.