GNU bug report logs - #27613
[PATCH] Support all perl variable declarators and prefixes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27613 in the body.
You can then email your comments to 27613 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Cc: Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com>
Subject: [PATCH] Support all perl variable declarators and prefixes
Date: Fri,  7 Jul 2017 17:08:52 -0500

Syntax highlight declarators and prefixes, and add all variable
definitions to imenu.
---
 lisp/progmodes/perl-mode.el | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lisp/progmodes/perl-mode.el b/lisp/progmodes/perl-mode.el
index 3def37a2ea..9cacfac336 100644
--- a/lisp/progmodes/perl-mode.el
+++ b/lisp/progmodes/perl-mode.el
@@ -135,7 +135,7 @@
   '(;; Functions
     (nil "^[ \t]*sub\\s-+\\([-[:alnum:]+_:]+\\)" 1)
     ;;Variables
-    ("Variables" "^\\(?:my\\|our\\)\\s-+\\([$@%][-[:alnum:]+_:]+\\)\\s-*=" 1)
+    ("Variables" "^[ \t]*\\(?:anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\s-+\\([$@%][-[:alnum:]+_:]+\\)\\s-*=" 1)
     ("Packages" "^[ \t]*package\\s-+\\([-[:alnum:]+_:]+\\);" 1)
     ("Doc sections" "^=head[0-9][ \t]+\\(.*\\)" 1))
   "Imenu generic expression for Perl mode.  See `imenu-generic-expression'.")
@@ -179,8 +179,9 @@
                             "BEGIN" "END" "return" "exec" "eval") t)
               "\\>")
      ;;
-     ;; Fontify local and my keywords as types.
-     ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
+     ;; Fontify declarators and prefixes as types.
+     ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
+     ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
      ;;
      ;; Fontify function, variable and file name references.
      ("&\\(\\sw+\\(::\\sw+\\)*\\)" 1 font-lock-function-name-face)
-- 
2.11.0

Message #10 received at 27613 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com>
Cc: 27613 <at> debbugs.gnu.org
Subject: Re: bug#27613: [PATCH] Support all perl variable declarators and
 prefixes
Date: Sun, 20 Aug 2017 22:27:06 -0400

Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com> writes:

> Syntax highlight declarators and prefixes, and add all variable
> definitions to imenu.

Looks good to me.  Have you done copyright assignment for Emacs?  (The
patch is small enough to apply regardless, I only ask to know whether I
should mark it as such or not.)

Message #13 received at 27613 <at> debbugs.gnu.org (full text, mbox):

From: Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: 27613 <at> debbugs.gnu.org
Subject: Re: bug#27613: [PATCH] Support all perl variable declarators and
 prefixes
Date: Wed, 23 Aug 2017 16:09:33 -0500

[Message part 1 (text/plain, inline)]

Thanks for looking it over.  No, I have not done copyright assignment.

On Sun, Aug 20, 2017 at 9:27 PM, <npostavs <at> users.sourceforge.net> wrote:

> Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com> writes:
>
> > Syntax highlight declarators and prefixes, and add all variable
> > definitions to imenu.
>
> Looks good to me.  Have you done copyright assignment for Emacs?  (The
> patch is small enough to apply regardless, I only ask to know whether I
> should mark it as such or not.)
>

[Message part 2 (text/html, inline)]

Message #16 received at 27613 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com>
Cc: 27613 <at> debbugs.gnu.org
Subject: Re: bug#27613: [PATCH] Support all perl variable declarators and
 prefixes
Date: Fri, 25 Aug 2017 23:09:44 -0400

tags 27613 fixed
close 27613 26.1
quit

Jefferson Carpenter <jeffersoncarpenter2 <at> gmail.com> writes:

> Thanks for looking it over. No, I have not done copyright assignment.

Okay, pushed to master.

[1: feecb66b6f]: 2017-08-25 22:50:15 -0400
  Support all perl variable declarators and prefixes (Bug#27613)
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=feecb66b6fe41c977b8e11b5f2d419c9544f42de>

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.