GNU bug report logs -
#27556
libpng has wrong hash.
Previous Next
Reported by: ng0 <ng0 <at> infotropique.org>
Date: Sun, 2 Jul 2017 20:15:01 UTC
Severity: normal
Done: Leo Famulari <leo <at> famulari.name>
Bug is archived. No further changes may be made.
Full log
Message #41 received at 27556 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
ng0 transcribed 2.5K bytes:
> Leo Famulari transcribed 2.2K bytes:
> > On Sun, Jul 30, 2017 at 09:37:22AM +0000, ng0 wrote:
> > > Efraim Flashner transcribed 4.1K bytes:
> > > > On Wed, Jul 26, 2017 at 06:56:51AM +0000, ng0 wrote:
> > > > > My really strong guess is that we never updated the hash for
> > > > > libpng-apng when the libpng was updated fron which libpng-apng
> > > > > inherits its version.
> >
> > [...]
> >
> > > > git blame shows that back in February I updated libpng to 1.6.28 from
> > > > 1.6.25, but that the last time libpng-apng was touched was by ng0 back
> > > > in January.
> > > >
> > > > commit: 864738baaa7bb75c08647ccfc684736479e67f7f
> >
> > Aha, that must be it!
> >
> > > Okay, so I will send the update for libpng-apng (which due to its
> > > inheritance of libpng is just the hash) and I will also add a second
> > > commit which adds a comment above libpng that we must update libpng-apng
> > > when we update libpng, if that's already possible (libpng-apng might not
> > > immediately be up to date, but we don't update libpng immediately aswell
> > > due to it being a core-updates candidate).
> >
> > I think we should give libpng-apng its own version because, as you said,
> > libpng-apng may not be developed at the same pace as libpng. This way,
> > we won't end up with a broken libpng-apng again.
I appended a patch how I understood your idea.
--
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org
[0001-gnu-libpng-apng-Update-to-1.6.28.patch (text/plain, attachment)]
[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 7 years and 352 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.