GNU bug report logs - #27557
26.0.50: patch org-edit-src-code

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27557 in the body.
You can then email your comments to 27557 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Fritz Stelzer <brotzeitmacher <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50: patch org-edit-src-code
Date: Sun, 2 Jul 2017 12:53:10 +0200

[Message part 1 (text/plain, inline)]

When I use "org-edit-special" in an org babel block, I get this traceback:

Debugger entered--Lisp error: (wrong-type-argument listp t)
  delete((org-filtered) t)
  remove((org-filtered) t)
  org-move-to-column(5)
  org-edit-src-code()
  org-edit-special(nil)
  funcall-interactively(org-edit-special nil)
  call-interactively(org-edit-special record nil)
  command-execute(org-edit-special record)
  execute-extended-command(nil "org-edit-special" "org-edit-sp")
  funcall-interactively(execute-extended-command nil "org-edit-special"
"org-edit-sp")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)


The reason for this seems to be a rewrite of the c function "delete", that
does not accept "t" instead of a list anymore. I guess it was done for a
reason.
I think "org-move-to-column" causes the problem as it is called in org-src
buffers. I tried "org-move-to-column" in an org buffer and it seems to work.



My solution would be to use "move-to-column" instead:


master ff87c8da24b40399f18f1c4c6fcab601287683ae
Author:     brotzeit <brotzeitmacher <at> gmail.com>
AuthorDate: Sun Jul 2 12:44:53 2017 +0200
Commit:     brotzeit <brotzeitmacher <at> gmail.com>
CommitDate: Sun Jul 2 12:44:53 2017 +0200

Parent:     9a2a7bb6e6 Let test summary go through even if some logs were
not generated
Merged:     master
Containing: master
Follows:    emacs-25.1 (129272)

use move-to-column in source block editing buffer

modified   lisp/org/org-src.el
@@ -356,13 +356,13 @@ org-edit-src-code
     (org-unescape-code-in-region (point-min) (point-max))
     (when markline
       (org-goto-line (1+ (- markline begline)))
-      (org-move-to-column
+      (move-to-column
        (if org-src-preserve-indentation markcol
          (max 0 (- markcol total-nindent))))
       (push-mark (point) 'no-message t)
       (setq deactivate-mark nil))
     (org-goto-line (1+ (- line begline)))
-    (org-move-to-column
+    (move-to-column
      (if org-src-preserve-indentation col (max 0 (- col total-nindent))))
     (org-src-mode)
     (set-buffer-modified-p nil)

[Message part 2 (text/html, inline)]

Message #8 received at 27557 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Fritz Stelzer <brotzeitmacher <at> gmail.com>
Cc: 27557 <at> debbugs.gnu.org
Subject: Re: bug#27557: 26.0.50: patch org-edit-src-code
Date: Mon, 03 Jul 2017 08:46:36 -0400

tags 27557 fixed
close 27557 
quit

Fritz Stelzer <brotzeitmacher <at> gmail.com> writes:

> When I use "org-edit-special" in an org babel block, I get this traceback:
>
> Debugger entered--Lisp error: (wrong-type-argument listp t)
> delete((org-filtered) t)
> remove((org-filtered) t)
> org-move-to-column(5)
> org-edit-src-code()
> org-edit-special(nil)

This seems to have been fixed with the recent org-mode update.

[1: 5cecd27582]: 2017-06-22 11:54:18 +0200
  Update Org to v9.0.9
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5cecd275820df825c51bf9a27fcc7e35f30ff273

[2: 1ce7864d1f]: 2017-06-22 11:54:27 +0200
  Add Org schemas.xml contents to Emacs schemas.xml
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=1ce7864d1f3fc81257193b8cece934f984285c92

[3: 5cfdf8dd17]: 2017-06-22 12:26:08 +0200
  ; Fix ORG-NEWS formatting in previous commit
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=5cfdf8dd17366e3ebf9f4e000b82a281c4183e66

[4: 896641b962]: 2017-06-23 10:58:09 +0200
  Synchronize with the "emacs-sync" branch from Org
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=896641b962443a6398ebe337cd78a6c1180971c1

[5: 20e006ffee]: 2017-06-23 10:59:16 +0200
  ; Fix version in orgcard.tex
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=20e006ffee41062f1b551a92c24d9edc53cd0f56

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.