GNU bug report logs - #27483
[PATCH] gnu: Add python-pass-git-helper.

Previous Next

Full log

Message #11 received at 27483 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <wordempire <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Jelle Licht <jlicht <at> fsfe.org>, 27483 <at> debbugs.gnu.org
Subject: Re: [bug#27483] [PATCH] gnu: Add python-pass-git-helper.
Date: Sun, 25 Jun 2017 19:56:57 +0200

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:
> Thanks for the patch!
>
>> +(define-public python-pass-git-helper
>> +  (package
>> +    (name "python-pass-git-helper")
>
> Since, this is an application, not a python library, this package should
> not have the "python-" prefix. It should just be called pass-git-helper.
>
>> +    (version "0.3")
>
> The latest version is 0.3.1. However, this is only available on the
> project's github releases page. Could you try with that?
>
> https://github.com/languitar/pass-git-helper/releases
>
>> +    (description
>> +     "A git credential helper implementation which allows to use pass, the
>> +standard unix password manager, as the credential backend for your git
>> +repositories.  This is achieved by explicitly defining mappings between hosts
>> +and entries in the password store.")
>
> Descriptions should use full sentences. Could you rephrase the first
> sentence to comply?
>
> https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html
>
>> +    (license license:lgpl3)))
>
> The license is lgpl3+. Look at line 17 of setup.py.
>
> Everything else LGTM. Could you send an updated patch?

Done!

[0001-gnu-Add-pass-git-helper.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.