GNU bug report logs - #27483
[PATCH] gnu: Add python-pass-git-helper.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27483 in the body.
You can then email your comments to 27483 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <jlicht <at> fsfe.org>
To: guix-patches <at> gnu.org
Cc: Jelle Licht <jlicht <at> fsfe.org>
Subject: [PATCH] gnu: Add python-pass-git-helper.
Date: Sun, 25 Jun 2017 14:39:47 +0200

* gnu/packages/password-utils.scm (python-pass-git-helper): New variable.
---
 gnu/packages/password-utils.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 9cfacdb42..55b6e2a04 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -37,6 +37,7 @@
   #:use-module (gnu packages aidc)
   #:use-module (gnu packages base)
   #:use-module (gnu packages compression)
+  #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
@@ -410,3 +411,38 @@ Password Scheme\"} by Niels Provos and David Mazieres.")
 
 (define-public python2-bcrypt
   (package-with-python2 python-bcrypt))
+
+(define-public python-pass-git-helper
+  (package
+    (name "python-pass-git-helper")
+    (version "0.3")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pass-git-helper" version))
+       (sha256
+        (base32
+         "1zxzwljz8zqayd6dcai6y9qkj2ingbk89z20hqqvcr62a5bjks7v"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'build 'patch-pass-path
+                 (lambda* (#:key inputs #:allow-other-keys)
+                   (let* ((password-store (assoc-ref inputs "password-store"))
+                          (pass           (string-append password-store
+                                                         "/bin/pass")))
+                     (substitute* "pass-git-helper"
+                       (("'pass'") (string-append "'" pass "'")))
+                     #t))))))
+    (inputs
+     `(("python-pyxdg" ,python-pyxdg)
+       ("password-store" ,password-store)))
+    (home-page "https://github.com/languitar/pass-git-helper")
+    (synopsis "Git credential helper interfacing with pass")
+    (description
+     "A git credential helper implementation which allows to use pass, the
+standard unix password manager, as the credential backend for your git
+repositories.  This is achieved by explicitly defining mappings between hosts
+and entries in the password store.")
+    (license license:lgpl3)))
-- 
2.13.1

Message #8 received at 27483 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 27483 <at> debbugs.gnu.org
Subject: Re: [bug#27483] [PATCH] gnu: Add python-pass-git-helper.
Date: Sun, 25 Jun 2017 22:52:44 +0530

Thanks for the patch!

> +(define-public python-pass-git-helper
> +  (package
> +    (name "python-pass-git-helper")

Since, this is an application, not a python library, this package should
not have the "python-" prefix. It should just be called pass-git-helper.

> +    (version "0.3")

The latest version is 0.3.1. However, this is only available on the
project's github releases page. Could you try with that?

https://github.com/languitar/pass-git-helper/releases

> +    (description
> +     "A git credential helper implementation which allows to use pass, the
> +standard unix password manager, as the credential backend for your git
> +repositories.  This is achieved by explicitly defining mappings between hosts
> +and entries in the password store.")

Descriptions should use full sentences. Could you rephrase the first
sentence to comply?

https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html

> +    (license license:lgpl3)))

The license is lgpl3+. Look at line 17 of setup.py.

Everything else LGTM. Could you send an updated patch?

Message #11 received at 27483 <at> debbugs.gnu.org (full text, mbox):

From: Jelle Licht <wordempire <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Jelle Licht <jlicht <at> fsfe.org>, 27483 <at> debbugs.gnu.org
Subject: Re: [bug#27483] [PATCH] gnu: Add python-pass-git-helper.
Date: Sun, 25 Jun 2017 19:56:57 +0200

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:
> Thanks for the patch!
>
>> +(define-public python-pass-git-helper
>> +  (package
>> +    (name "python-pass-git-helper")
>
> Since, this is an application, not a python library, this package should
> not have the "python-" prefix. It should just be called pass-git-helper.
>
>> +    (version "0.3")
>
> The latest version is 0.3.1. However, this is only available on the
> project's github releases page. Could you try with that?
>
> https://github.com/languitar/pass-git-helper/releases
>
>> +    (description
>> +     "A git credential helper implementation which allows to use pass, the
>> +standard unix password manager, as the credential backend for your git
>> +repositories.  This is achieved by explicitly defining mappings between hosts
>> +and entries in the password store.")
>
> Descriptions should use full sentences. Could you rephrase the first
> sentence to comply?
>
> https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html
>
>> +    (license license:lgpl3)))
>
> The license is lgpl3+. Look at line 17 of setup.py.
>
> Everything else LGTM. Could you send an updated patch?

Done!

[0001-gnu-Add-pass-git-helper.patch (text/x-patch, attachment)]

Message #16 received at 27483-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Jelle Licht <jlicht <at> fsfe.org>
Cc: 27483-done <at> debbugs.gnu.org
Subject: Re: [bug#27483] [PATCH] gnu: Add python-pass-git-helper.
Date: Mon, 26 Jun 2017 02:15:31 +0530

Pushed! Thanks!

I added a copyright header for you, and made a few other minor stylistic
changes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.