GNU bug report logs - #27453
25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format

Previous Next

Package: emacs;

Reported by: Rohan Hart <rohan.hart <at> fronde.com>

Date: Fri, 23 Jun 2017 01:27:02 UTC

Severity: minor

Found in version 25.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Rohan Hart <rohan.hart <at> fronde.com>
Cc: 27453 <at> debbugs.gnu.org
Subject: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format
Date: Tue, 23 Jul 2019 13:31:59 +0200
Rohan Hart <rohan.hart <at> fronde.com> writes:

> Well sure, I only raised this as log-view states:
>
> ;; Currently supports the format output by:
> ;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.
>
> And later mentions code related to both darcsum and vc-darcs.

Then perhaps it does make sense to add the regexp to log-view-message-re
after all.  The current definition is:

(defvar log-view-message-re
  (concat "^\\(?:revision \\(?1:[.0-9]+\\)\\(?:\t.*\\)?" ; RCS and CVS.
          "\\|r\\(?1:[0-9]+\\) | .* | .*"                ; Subversion.
          "\\|D \\(?1:[.0-9]+\\) .*"                     ; SCCS.
          ;; Darcs doesn't have revision names.  VC-darcs uses patch names
          ;; instead.  Darcs patch names are hashcodes, which do not appear
          ;; in the log output :-(, but darcs accepts any prefix of the log
          ;; message as a patch name, so we match the first line of the log
          ;; message.
          ;; First loosely match the date format.
          (concat "\\|[^ \n].*[^0-9\n][0-9][0-9]:[0-9][0-9][^0-9\n].*[^ \n]"
                  ;;Email of user and finally Msg, used as revision name.
                  "  .*@.*\n\\(?:  \\* \\(?1:.*\\)\\)?")
          "\\)$")

Is VC-darcs something else than darcs?  Or is that an Emacs package?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




This bug report was last modified 4 years and 279 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.