GNU bug report logs - #27453
25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs log format

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27453 in the body.
You can then email your comments to 27453 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rohan Hart <rohan.hart <at> fronde.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.1; vc/log-view.el log-view-message-re doesn't support newer Darcs
 log format
Date: Fri, 23 Jun 2017 00:49:33 +0000

[Message part 1 (text/plain, inline)]

Darcs now shows the internal hash for each patch in a format like:

patch f4128969c4700a0b34414390d04159cb6b11b4e5
Author: bob <bob>
Date:   Sun May 21 22:44:55 NZST 2017
  * patch name
  - further details

Adding the regex "\\|^patch \\(?1:[.0-9a-f]+\\)" to log-view-message-re
seems to be sufficient to use the hash.

cheers
Rohan
-- 
| Rohan Hart | Consultant | Fronde Systems Group Ltd
| 3 Queens Wharf | PO Box 11545 | Wellington 6142, New Zealand
| p. +64 4 499 3000 | ddi. +64 4 439 4080 | m. +64 21 937 533
| e. rohan.hart <at> fronde.com | w. www.fronde.com

-- 
The information contained in this email is privileged and confidential and 
intended for the addressee only. If you are not the intended recipient, 
please respect that confidentiality and do not disclose, copy or make use 
of its contents. If received in error, please destroy this email and 
contact the sender immediately. Thank you.

[Message part 2 (text/html, inline)]

Message #8 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Rohan Hart <rohan.hart <at> fronde.com>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Sun, 21 Jul 2019 19:40:25 +0200

Rohan Hart <rohan.hart <at> fronde.com> writes:

> Darcs now shows the internal hash for each patch in a format like:
>
> patch f4128969c4700a0b34414390d04159cb6b11b4e5
> Author: bob <bob>
> Date:   Sun May 21 22:44:55 NZST 2017
>   * patch name
>   - further details
>
> Adding the regex "\\|^patch \\(?1:[.0-9a-f]+\\)" to log-view-message-re
> seems to be sufficient to use the hash.

Hm...  Unless I'm mistaken, Emacs doesn't support Darcs?  I ran

$ darcs clone https://hub.darcs.net/onetom/0wnDB

and Emacs then claimed that the files in that directory weren't under
source control?  So I'm unsure how this would help...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Rohan Hart <rohan.hart <at> fronde.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Mon, 22 Jul 2019 08:36:28 +1200

[Message part 1 (text/plain, inline)]

Hi Lars

Emacs doesn't support Darcs out of the box. See
https://www.emacswiki.org/emacs/DaRcs

cheers
Rohan

On Mon, 22 Jul 2019 at 05:40, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Rohan Hart <rohan.hart <at> fronde.com> writes:
>
> > Darcs now shows the internal hash for each patch in a format like:
> >
> > patch f4128969c4700a0b34414390d04159cb6b11b4e5
> > Author: bob <bob>
> > Date:   Sun May 21 22:44:55 NZST 2017
> >   * patch name
> >   - further details
> >
> > Adding the regex "\\|^patch \\(?1:[.0-9a-f]+\\)" to log-view-message-re
> > seems to be sufficient to use the hash.
>
> Hm...  Unless I'm mistaken, Emacs doesn't support Darcs?  I ran
>
> $ darcs clone https://hub.darcs.net/onetom/0wnDB
>
> and Emacs then claimed that the files in that directory weren't under
> source control?  So I'm unsure how this would help...
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>


-- 

*Rohan Hart*
Technical Lead Developer
Fronde


[image: Fronde Logo]

Level 1, 222 Lambton Quay | PO Box 11-545 | Wellington 6011, New Zealand
m. +64 21 937 533  | e. rohan.hart <at> fronde.com | w. www.fronde.com

-- 
The information contained in this email is privileged and confidential and 
intended for the addressee only. If you are not the intended recipient, 
please respect that confidentiality and do not disclose, copy or make use 
of its contents. If received in error, please destroy this email and 
contact the sender immediately. Thank you.

[Message part 2 (text/html, inline)]

Message #14 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Rohan Hart <rohan.hart <at> fronde.com>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Mon, 22 Jul 2019 14:28:10 +0200

Rohan Hart <rohan.hart <at> fronde.com> writes:

> Emacs doesn't support Darcs out of the box. See
> https://www.emacswiki.org/emacs/DaRcs

Wouldn't it then be up to these external packages to extend
`log-view-message-re' to match the formats?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Rohan Hart <rohan.hart <at> fronde.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Tue, 23 Jul 2019 08:42:40 +1200

[Message part 1 (text/plain, inline)]

Well sure, I only raised this as log-view states:

;; Currently supports the format output by:
;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.

And later mentions code related to both darcsum and vc-darcs.

I'll raise it with the other packages

cheers

On Tue, 23 Jul 2019 at 00:28, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Rohan Hart <rohan.hart <at> fronde.com> writes:
>
> > Emacs doesn't support Darcs out of the box. See
> > https://www.emacswiki.org/emacs/DaRcs
>
> Wouldn't it then be up to these external packages to extend
> `log-view-message-re' to match the formats?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>


-- 

*Rohan Hart*
Technical Lead Developer
Fronde


[image: Fronde Logo]

Level 1, 222 Lambton Quay | PO Box 11-545 | Wellington 6011, New Zealand
m. +64 21 937 533  | e. rohan.hart <at> fronde.com | w. www.fronde.com

-- 
The information contained in this email is privileged and confidential and 
intended for the addressee only. If you are not the intended recipient, 
please respect that confidentiality and do not disclose, copy or make use 
of its contents. If received in error, please destroy this email and 
contact the sender immediately. Thank you.

[Message part 2 (text/html, inline)]

Message #20 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Rohan Hart <rohan.hart <at> fronde.com>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Tue, 23 Jul 2019 13:31:59 +0200

Rohan Hart <rohan.hart <at> fronde.com> writes:

> Well sure, I only raised this as log-view states:
>
> ;; Currently supports the format output by:
> ;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.
>
> And later mentions code related to both darcsum and vc-darcs.

Then perhaps it does make sense to add the regexp to log-view-message-re
after all.  The current definition is:

(defvar log-view-message-re
  (concat "^\\(?:revision \\(?1:[.0-9]+\\)\\(?:\t.*\\)?" ; RCS and CVS.
          "\\|r\\(?1:[0-9]+\\) | .* | .*"                ; Subversion.
          "\\|D \\(?1:[.0-9]+\\) .*"                     ; SCCS.
          ;; Darcs doesn't have revision names.  VC-darcs uses patch names
          ;; instead.  Darcs patch names are hashcodes, which do not appear
          ;; in the log output :-(, but darcs accepts any prefix of the log
          ;; message as a patch name, so we match the first line of the log
          ;; message.
          ;; First loosely match the date format.
          (concat "\\|[^ \n].*[^0-9\n][0-9][0-9]:[0-9][0-9][^0-9\n].*[^ \n]"
                  ;;Email of user and finally Msg, used as revision name.
                  "  .*@.*\n\\(?:  \\* \\(?1:.*\\)\\)?")
          "\\)$")

Is VC-darcs something else than darcs?  Or is that an Emacs package?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #23 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Rohan Hart <rohan.hart <at> fronde.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Wed, 24 Jul 2019 08:57:09 +1200

[Message part 1 (text/plain, inline)]

vc-darcs is the emacs package for darcs integration with vc.

If you wished to support very old versions of darcs then keep that complex
match and put the new one before it. Not that I've tested that config - I
just override the entire log-view-message-re as I don't use any of those
other version control systems

thanks

On Tue, 23 Jul 2019 at 23:32, Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Rohan Hart <rohan.hart <at> fronde.com> writes:
>
> > Well sure, I only raised this as log-view states:
> >
> > ;; Currently supports the format output by:
> > ;; SCCS, RCS, CVS, Subversion, DaRCS, and Mercurial.
> >
> > And later mentions code related to both darcsum and vc-darcs.
>
> Then perhaps it does make sense to add the regexp to log-view-message-re
> after all.  The current definition is:
>
> (defvar log-view-message-re
>   (concat "^\\(?:revision \\(?1:[.0-9]+\\)\\(?:\t.*\\)?" ; RCS and CVS.
>           "\\|r\\(?1:[0-9]+\\) | .* | .*"                ; Subversion.
>           "\\|D \\(?1:[.0-9]+\\) .*"                     ; SCCS.
>           ;; Darcs doesn't have revision names.  VC-darcs uses patch names
>           ;; instead.  Darcs patch names are hashcodes, which do not appear
>           ;; in the log output :-(, but darcs accepts any prefix of the log
>           ;; message as a patch name, so we match the first line of the log
>           ;; message.
>           ;; First loosely match the date format.
>           (concat "\\|[^ \n].*[^0-9\n][0-9][0-9]:[0-9][0-9][^0-9\n].*[^
> \n]"
>                   ;;Email of user and finally Msg, used as revision name.
>                   "  .*@.*\n\\(?:  \\* \\(?1:.*\\)\\)?")
>           "\\)$")
>
> Is VC-darcs something else than darcs?  Or is that an Emacs package?
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no
>


-- 

*Rohan Hart*
Technical Lead Developer
Fronde


[image: Fronde Logo]

Level 1, 222 Lambton Quay | PO Box 11-545 | Wellington 6011, New Zealand
m. +64 21 937 533  | e. rohan.hart <at> fronde.com | w. www.fronde.com

-- 
The information contained in this email is privileged and confidential and 
intended for the addressee only. If you are not the intended recipient, 
please respect that confidentiality and do not disclose, copy or make use 
of its contents. If received in error, please destroy this email and 
contact the sender immediately. Thank you.

[Message part 2 (text/html, inline)]

Message #26 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Rohan Hart <rohan.hart <at> fronde.com>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Wed, 24 Jul 2019 14:32:55 +0200

Rohan Hart <rohan.hart <at> fronde.com> writes:

> vc-darcs is the emacs package for darcs integration with vc.
>
> If you wished to support very old versions of darcs then keep that complex
> match and put the new one before it. Not that I've tested that config - I just
> override the entire log-view-message-re as I don't use any of those other
> version control systems

As this isn't something I can test myself, can you post a patch to
log-view.el that you've verified works for you?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #29 received at 27453 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Rohan Hart <rohan.hart <at> fronde.com>
Cc: 27453 <at> debbugs.gnu.org
Subject: Re: bug#27453: 25.1; vc/log-view.el log-view-message-re doesn't
 support newer Darcs log format
Date: Thu, 20 Aug 2020 18:01:49 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Rohan Hart <rohan.hart <at> fronde.com> writes:
>
>> vc-darcs is the emacs package for darcs integration with vc.
>>
>> If you wished to support very old versions of darcs then keep that complex
>> match and put the new one before it. Not that I've tested that config - I just
>> override the entire log-view-message-re as I don't use any of those other
>> version control systems
>
> As this isn't something I can test myself, can you post a patch to
> log-view.el that you've verified works for you?

More information was requested, but no response was given within a yes,
so I'm closing this bug report.  If this is something that should still
be worked on, please respond to this email and we'll reopen the bug
report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.