GNU bug report logs - #27441
[PATCH] gnu: Update calibre to 3.0.0.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Roel Janssen <roel <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#27441: closed ([PATCH] gnu: Update calibre to 3.0.0.)
Date: Wed, 21 Jun 2017 22:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 22 Jun 2017 00:12:03 +0200
with message-id <87a851vvm4.fsf <at> gnu.org>
and subject line Re: [bug#27441] [PATCH] gnu: Update calibre to 3.0.0.
has caused the debbugs.gnu.org bug report #27441,
regarding [PATCH] gnu: Update calibre to 3.0.0.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
27441: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27441
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Update calibre to 3.0.0.
Date: Wed, 21 Jun 2017 15:14:03 +0200

[Message part 3 (text/plain, inline)]

Dear Guix,

I changed the calibre recipe to accomodate for the changes for 3.0.0.
In the process I replaced one of the patches that removed the external
links to favicons with a substitution.  (The patch wouldn't apply
anymore).

So, the following patch updates calibre to 3.0.0.  I tested that it
works and that I can copy books to my e-reader.  .. And of course that
works fine.

Kind regards,
Roel Janssen

[0001-gnu-Update-calibre-to-3.0.0.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27441-done <at> debbugs.gnu.org
Subject: Re: [bug#27441] [PATCH] gnu: Update calibre to 3.0.0.
Date: Thu, 22 Jun 2017 00:12:03 +0200

Ludovic Courtès writes:

> Roel Janssen <roel <at> gnu.org> skribis:
>
>> From bbdc3f943d48d92c7be3aee6891dcfb26ba5b186 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Wed, 21 Jun 2017 16:44:56 +0200
>> Subject: [PATCH] gnu: Update calibre to 3.0.0.
>>
>> * gnu/local.mk: Remove patch.
>> * gnu/packages/ebook.scm (calibre): Update to 3.0.0.
>> * gnu/packages/patches/calibre-dont-load-remote-icons.patch: Remove file.
>
> [...]
>
>> +         (add-after 'unpack 'dont-load-remote-icons
>> +           (lambda _
>> +             (substitute* "setup/plugins_mirror.py"
>> +               (("href=\"//calibre-ebook.com/favicon.ico\"")
>> +                "href=\"favicon.ico\""))))
>
> Make sure to return #t.
>
> Other than that, if it works for you, I say go for it!

I added the #t to the end of the lambda and pushed in f70f3407.

Thanks!

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.