GNU bug report logs - #27441
[PATCH] gnu: Update calibre to 3.0.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27441 in the body.
You can then email your comments to 27441 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Update calibre to 3.0.0.
Date: Wed, 21 Jun 2017 15:14:03 +0200

[Message part 1 (text/plain, inline)]

Dear Guix,

I changed the calibre recipe to accomodate for the changes for 3.0.0.
In the process I replaced one of the patches that removed the external
links to favicons with a substitution.  (The patch wouldn't apply
anymore).

So, the following patch updates calibre to 3.0.0.  I tested that it
works and that I can copy books to my e-reader.  .. And of course that
works fine.

Kind regards,
Roel Janssen

[0001-gnu-Update-calibre-to-3.0.0.patch (text/x-patch, attachment)]

Message #8 received at 27441 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: 27441 <at> debbugs.gnu.org
Subject: Re: [bug#27441] [PATCH] gnu: Update calibre to 3.0.0.
Date: Wed, 21 Jun 2017 16:47:37 +0200

[Message part 1 (text/plain, inline)]

Dear Guix,

I forgot to remove the patch from local.mk.
Here's a new patch that includes this change.

Kind regards,
Roel Janssen

[0001-gnu-Update-calibre-to-3.0.0.patch (text/x-patch, attachment)]

Message #11 received at 27441 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 27441 <at> debbugs.gnu.org
Subject: Re: [bug#27441] [PATCH] gnu: Update calibre to 3.0.0.
Date: Wed, 21 Jun 2017 21:36:48 +0200

Roel Janssen <roel <at> gnu.org> skribis:

> From bbdc3f943d48d92c7be3aee6891dcfb26ba5b186 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Wed, 21 Jun 2017 16:44:56 +0200
> Subject: [PATCH] gnu: Update calibre to 3.0.0.
>
> * gnu/local.mk: Remove patch.
> * gnu/packages/ebook.scm (calibre): Update to 3.0.0.
> * gnu/packages/patches/calibre-dont-load-remote-icons.patch: Remove file.

[...]

> +         (add-after 'unpack 'dont-load-remote-icons
> +           (lambda _
> +             (substitute* "setup/plugins_mirror.py"
> +               (("href=\"//calibre-ebook.com/favicon.ico\"")
> +                "href=\"favicon.ico\""))))

Make sure to return #t.

Other than that, if it works for you, I say go for it!

Thanks,
Ludo’.

Message #16 received at 27441-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27441-done <at> debbugs.gnu.org
Subject: Re: [bug#27441] [PATCH] gnu: Update calibre to 3.0.0.
Date: Thu, 22 Jun 2017 00:12:03 +0200

Ludovic Courtès writes:

> Roel Janssen <roel <at> gnu.org> skribis:
>
>> From bbdc3f943d48d92c7be3aee6891dcfb26ba5b186 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Wed, 21 Jun 2017 16:44:56 +0200
>> Subject: [PATCH] gnu: Update calibre to 3.0.0.
>>
>> * gnu/local.mk: Remove patch.
>> * gnu/packages/ebook.scm (calibre): Update to 3.0.0.
>> * gnu/packages/patches/calibre-dont-load-remote-icons.patch: Remove file.
>
> [...]
>
>> +         (add-after 'unpack 'dont-load-remote-icons
>> +           (lambda _
>> +             (substitute* "setup/plugins_mirror.py"
>> +               (("href=\"//calibre-ebook.com/favicon.ico\"")
>> +                "href=\"favicon.ico\""))))
>
> Make sure to return #t.
>
> Other than that, if it works for you, I say go for it!

I added the #t to the end of the lambda and pushed in f70f3407.

Thanks!

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.