GNU bug report logs - #27419
[PATCH] gnu: Add unbound.

Previous Next

Full log

View this message in rfc822 format

From: Gregor Giesen <giesen <at> zaehlwerk.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27419 <at> debbugs.gnu.org
Subject: [bug#27419] [PATCH] gnu: Add unbound.
Date: Mon, 19 Jun 2017 18:38:58 +0200

[Message part 1 (text/plain, inline)]

Dear Ludo’,

many thanks for the feedback! I have fixed the minor issues you
mentioned.

On Mon, Jun 19, 2017 at 02:14:29PM +0200, Ludovic Courtès wrote:
> > +    (outputs '("out" "python"))
> > +    (inputs
> > +     `(("expat" ,expat)
> > +       ("flex" ,flex)
> > +       ("libevent" ,libevent)
> > +       ("protobuf" ,protobuf)
> > +       ("python" ,python-3)
> > +       ("python-wrapper" ,python-wrapper)
> > +       ("openssl" ,openssl)
> > +       ("swig" ,swig)))
> 
> I think SWIG should go to ‘native-inputs’ because it’s only used at
> build time.
Right, and I also moved ‘flex’ there. 

> > +             (let* ((source (assoc-ref %build-inputs "source"))
> > +                    (gcc (assoc-ref %build-inputs "gcc")))
> > +               (call-with-output-file "/tmp/nss_preload.c"
> > +                 (lambda (port)
> > +                   (display "#include <stdlib.h>
> 
> As discussed on help-guix, I would prefer using ‘substitute*’ to modify
> all the unit tests.  That would reduce complexity and be potentially
> more robust.  Does that sound feasible without much hassle?
Substituting is not not an option since after changing a record in the
test data one would have to create (cryptographically) new matching RRSIG 
records otherwise the test would still fail.

> That’s it, thank you for this first package!
Thanks again for your help! Attached is the modified patch.

Best,
Gregor

[0001-gnu-Add-unbound.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.