GNU bug report logs - #27419
[PATCH] gnu: Add unbound.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27419 in the body.
You can then email your comments to 27419 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gregor Giesen <giesen <at> zaehlwerk.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add unbound.
Date: Sun, 18 Jun 2017 14:51:43 +0200

[Message part 1 (text/plain, inline)]

Hi, 

I have added 'unbound', a recurse only caching DNS server.

Best,
Gregor

[0001-gnu-Add-unbound.patch (text/plain, attachment)]

Message #8 received at 27419 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Gregor Giesen <giesen <at> zaehlwerk.net>
Cc: 27419 <at> debbugs.gnu.org
Subject: Re: [bug#27419] [PATCH] gnu: Add unbound.
Date: Mon, 19 Jun 2017 14:14:29 +0200

Hi Gregor,

Gregor Giesen <giesen <at> zaehlwerk.net> skribis:

> From fac67e33fe0501ddcad3a1e75f20b4954f36834b Mon Sep 17 00:00:00 2001
> From: Gregor Giesen <giesen <at> zaehlwerk.net>
> Date: Sun, 18 Jun 2017 14:27:34 +0200
> Subject: [PATCH 1/1] gnu: Add unbound.
>
> * gnu/packages/dns.scm (unbound): New variable.

Nice!  Overall LGTM, so I’m commenting on minor issues:

> +    (outputs '("out" "python"))
> +    (inputs
> +     `(("expat" ,expat)
> +       ("flex" ,flex)
> +       ("libevent" ,libevent)
> +       ("protobuf" ,protobuf)
> +       ("python" ,python-3)
> +       ("python-wrapper" ,python-wrapper)
> +       ("openssl" ,openssl)
> +       ("swig" ,swig)))

I think SWIG should go to ‘native-inputs’ because it’s only used at
build time.

> +       (modify-phases
> +           %standard-phases

I would make this a single line.  :-)

> +         (add-after 'configure 'fix-python-site-package-path
> +           ;; Move python modules into their own output.
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((pyout (assoc-ref outputs "python"))
> +                   (ver ,(version-major+minor (package-version python))))
> +               (substitute* "Makefile"
> +                 (("^PYTHON_SITE_PKG=.*$")
> +                  (string-append
> +                   "PYTHON_SITE_PKG="
> +                   pyout "/lib/python-" ver "/site-packages\n"))))))

Please make sure the phase explicitly returns #t to indicate success.

> +         (add-before 'check 'fix-missing-nss-for-tests
> +           (lambda* (#:key inputs outputs #:allow-other-keys)
> +             (use-modules (guix build utils))

The ‘use-modules’ line is not needed.

> +             (let* ((source (assoc-ref %build-inputs "source"))
> +                    (gcc (assoc-ref %build-inputs "gcc")))
> +               (call-with-output-file "/tmp/nss_preload.c"
> +                 (lambda (port)
> +                   (display "#include <stdlib.h>

As discussed on help-guix, I would prefer using ‘substitute*’ to modify
all the unit tests.  That would reduce complexity and be potentially
more robust.  Does that sound feasible without much hassle?

> +               (substitute* "Makefile"
> +                 (("./unittest")
> +                  "LD_PRELOAD=/tmp/nss_preload.so ./unittest"))))))))

Also return #t.

> +    (home-page "https://www.unbound.net")
> +    (synopsis "Validating, recursive, and caching DNS resolver")
> +    (description
> +     "Unbound is a recursive-only caching DNS server which can perform DNSSEC validation of results.  It implements only a minimal amount of authoritative service to prevent leakage to the root nameservers: forward lookups for localhost, reverse for 127.0.0.1 and ::1, and NXDOMAIN for zones served by AS112.  Stub and forward zones are supported.")

Please wrap lines to 80 chars as ‘guix lint’ should suggest.  Also you
can write @code{127.0.0.1} and @code{::1}.

That’s it, thank you for this first package!

Ludo’.

Message #11 received at 27419 <at> debbugs.gnu.org (full text, mbox):

From: Gregor Giesen <giesen <at> zaehlwerk.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27419 <at> debbugs.gnu.org
Subject: Re: [bug#27419] [PATCH] gnu: Add unbound.
Date: Mon, 19 Jun 2017 18:38:58 +0200

[Message part 1 (text/plain, inline)]

Dear Ludo’,

many thanks for the feedback! I have fixed the minor issues you
mentioned.

On Mon, Jun 19, 2017 at 02:14:29PM +0200, Ludovic Courtès wrote:
> > +    (outputs '("out" "python"))
> > +    (inputs
> > +     `(("expat" ,expat)
> > +       ("flex" ,flex)
> > +       ("libevent" ,libevent)
> > +       ("protobuf" ,protobuf)
> > +       ("python" ,python-3)
> > +       ("python-wrapper" ,python-wrapper)
> > +       ("openssl" ,openssl)
> > +       ("swig" ,swig)))
> 
> I think SWIG should go to ‘native-inputs’ because it’s only used at
> build time.
Right, and I also moved ‘flex’ there. 

> > +             (let* ((source (assoc-ref %build-inputs "source"))
> > +                    (gcc (assoc-ref %build-inputs "gcc")))
> > +               (call-with-output-file "/tmp/nss_preload.c"
> > +                 (lambda (port)
> > +                   (display "#include <stdlib.h>
> 
> As discussed on help-guix, I would prefer using ‘substitute*’ to modify
> all the unit tests.  That would reduce complexity and be potentially
> more robust.  Does that sound feasible without much hassle?
Substituting is not not an option since after changing a record in the
test data one would have to create (cryptographically) new matching RRSIG 
records otherwise the test would still fail.

> That’s it, thank you for this first package!
Thanks again for your help! Attached is the modified patch.

Best,
Gregor

[0001-gnu-Add-unbound.patch (text/plain, attachment)]

Message #16 received at 27419-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Gregor Giesen <giesen <at> zaehlwerk.net>
Cc: 27419-done <at> debbugs.gnu.org
Subject: Re: [bug#27419] [PATCH] gnu: Add unbound.
Date: Tue, 20 Jun 2017 22:08:42 +0200

Hi Gregor,

Gregor Giesen <giesen <at> zaehlwerk.net> skribis:

> From 509b07d745dbe852259370cd7fbe0a6cfdcee9d7 Mon Sep 17 00:00:00 2001
> From: Gregor Giesen <giesen <at> zaehlwerk.net>
> Date: Sun, 18 Jun 2017 14:27:34 +0200
> Subject: [PATCH 1/1] gnu: Add unbound.
>
> * gnu/packages/dns.scm (unbound): New variable.

[...]

> +    (license license:bsd-3)))

On closer inspection it turns out to be
<https://directory.fsf.org/wiki/License:BSD_4Clause> so I changed that
to ‘bsd-4’.

Applied with this change, thank you!

“guix build unbound --rounds=2 -K” shows differences in libunbound.a.
Perhaps we should simply remove it?

Ludo’.

Message #19 received at 27419 <at> debbugs.gnu.org (full text, mbox):

From: Gregor Giesen <giesen <at> zaehlwerk.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 27419 <at> debbugs.gnu.org
Subject: Re: [bug#27419] [PATCH] gnu: Add unbound.
Date: Tue, 20 Jun 2017 22:27:38 +0200

Dear Ludo’,

On Tue, Jun 20, 2017 at 10:08:42PM +0200, Ludovic Courtès wrote:
> > +    (license license:bsd-3)))
> 
> On closer inspection it turns out to be
> <https://directory.fsf.org/wiki/License:BSD_4Clause> so I changed that
> to ‘bsd-4’.
sorry, my bad! 

> Applied with this change, thank you!
> 
> “guix build unbound --rounds=2 -K” shows differences in libunbound.a.
> Perhaps we should simply remove it?
Yes, I don't think we need it. We could simply add "--disable-static" to
the #:configure-flags.

Best,
Gregor

Message #22 received at 27419 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Gregor Giesen <giesen <at> zaehlwerk.net>
Cc: 27419 <at> debbugs.gnu.org
Subject: Re: [bug#27419] [PATCH] gnu: Add unbound.
Date: Wed, 21 Jun 2017 10:19:37 +0200

Hi,

Gregor Giesen <giesen <at> zaehlwerk.net> skribis:

>> “guix build unbound --rounds=2 -K” shows differences in libunbound.a.
>> Perhaps we should simply remove it?
> Yes, I don't think we need it. We could simply add "--disable-static" to
> the #:configure-flags.

Sounds good to me, I’ve committed this change.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.