GNU bug report logs - #2737
[PATCH] Emacs CVS: (rcirc): Save call args to history variables

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Jari Aalto <jari.aalto <at> cante.net>
Subject: bug#2737 closed by Chong Yidong <cyd <at> stupidchicken.com> (Re:
 [PATCH] Emacs CVS: (rcirc): Save call args to history variables)
Date: Wed, 15 Jul 2009 16:05:17 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#2737: [PATCH] Emacs CVS: (rcirc): Save call args to history variables

It has been closed by Chong Yidong <cyd <at> stupidchicken.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <cyd <at> stupidchicken.com> by
replying to this email.


-- 
2737: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2737
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: Ryan Yeske  <rcyeske <at> gmail.com>, 2737-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Emacs CVS: (rcirc): Save call args to history variables
Date: Wed, 15 Jul 2009 11:08:46 -0400

I've checked this patch into the trunk.  (I renamed your history
variables from rcirc-history-* to rcirc-*-history, for conformity.)

Thanks.

[Message part 3 (message/rfc822, inline)]

From: Jari Aalto <jari.aalto <at> cante.net>
To: Emacs bug BTS <submit <at> debbugs.gnu.org>
Subject: [PATCH] Emacs CVS: (rcirc): Save call args to history variables
Date: Sat, 21 Mar 2009 18:28:14 +0200

[Message part 4 (text/plain, inline)]

Patch against CVS as of 2009-03-21 16:27 UTC

2009-03-21  Jari Aalto  <jari.aalto <at> cante.net>

        * net/rcirc.el (rcirc-history-server-name)
        (rcirc-history-server-port)
        (rcirc-history-nick-name): new variables.
        (rcirc): Use history variables.

[0001-lisp-net-rcirc.el-rcirc-Save-call-args-to-histor.patch (text/x-diff, inline)]

From 02c1deb5855e78168aab74b1199a48b72eb9656b Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Sat, 21 Mar 2009 18:25:11 +0200
Subject: [PATCH] lisp/net/rcirc.el: (rcirc): Save call args to history variables

---
 lisp/net/rcirc.el |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index f63237f..de4bdeb 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -359,6 +359,15 @@ and the cdr part is used for encoding."
 
 (defvar rcirc-startup-channels nil)
 
+(defvar rcirc-history-server-name nil
+  "History variable for \\[rcirc] call.")
+
+(defvar rcirc-history-server-port nil
+  "History variable for \\[rcirc] call.")
+
+(defvar rcirc-history-nick-name nil
+  "History variable for \\[rcirc] call.")
+
 ;;;###autoload
 (defun rcirc (arg)
   "Connect to all servers in `rcirc-server-alist'.
@@ -371,15 +380,18 @@ If ARG is non-nil, instead prompt for connection parameters."
       (let* ((server (completing-read "IRC Server: "
 				      rcirc-server-alist
 				      nil nil
-				      (caar rcirc-server-alist)))
+				      (caar rcirc-server-alist)
+				      'rcirc-history-server-name))
 	     (server-plist (cdr (assoc-string server rcirc-server-alist)))
 	     (port (read-string "IRC Port: "
 				(number-to-string
 				 (or (plist-get server-plist 'port)
-				     rcirc-default-port))))
+				     rcirc-default-port))
+				'rcirc-history-server-port))
 	     (nick (read-string "IRC Nick: "
 				(or (plist-get server-plist 'nick)
-				    rcirc-default-nick)))
+				    rcirc-default-nick)
+				'rcirc-history-nick-name))
 	     (channels (split-string
 			(read-string "IRC Channels: "
 				     (mapconcat 'identity
-- 
1.6.1.3

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.