GNU bug report logs - #2737
[PATCH] Emacs CVS: (rcirc): Save call args to history variables

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2737 in the body.
You can then email your comments to 2737 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jari Aalto <jari.aalto <at> cante.net>
To: Emacs bug BTS <submit <at> debbugs.gnu.org>
Subject: [PATCH] Emacs CVS: (rcirc): Save call args to history variables
Date: Sat, 21 Mar 2009 18:28:14 +0200

[Message part 1 (text/plain, inline)]

Patch against CVS as of 2009-03-21 16:27 UTC

2009-03-21  Jari Aalto  <jari.aalto <at> cante.net>

        * net/rcirc.el (rcirc-history-server-name)
        (rcirc-history-server-port)
        (rcirc-history-nick-name): new variables.
        (rcirc): Use history variables.

[0001-lisp-net-rcirc.el-rcirc-Save-call-args-to-histor.patch (text/x-diff, inline)]

From 02c1deb5855e78168aab74b1199a48b72eb9656b Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Sat, 21 Mar 2009 18:25:11 +0200
Subject: [PATCH] lisp/net/rcirc.el: (rcirc): Save call args to history variables

---
 lisp/net/rcirc.el |   18 +++++++++++++++---
 1 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index f63237f..de4bdeb 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -359,6 +359,15 @@ and the cdr part is used for encoding."
 
 (defvar rcirc-startup-channels nil)
 
+(defvar rcirc-history-server-name nil
+  "History variable for \\[rcirc] call.")
+
+(defvar rcirc-history-server-port nil
+  "History variable for \\[rcirc] call.")
+
+(defvar rcirc-history-nick-name nil
+  "History variable for \\[rcirc] call.")
+
 ;;;###autoload
 (defun rcirc (arg)
   "Connect to all servers in `rcirc-server-alist'.
@@ -371,15 +380,18 @@ If ARG is non-nil, instead prompt for connection parameters."
       (let* ((server (completing-read "IRC Server: "
 				      rcirc-server-alist
 				      nil nil
-				      (caar rcirc-server-alist)))
+				      (caar rcirc-server-alist)
+				      'rcirc-history-server-name))
 	     (server-plist (cdr (assoc-string server rcirc-server-alist)))
 	     (port (read-string "IRC Port: "
 				(number-to-string
 				 (or (plist-get server-plist 'port)
-				     rcirc-default-port))))
+				     rcirc-default-port))
+				'rcirc-history-server-port))
 	     (nick (read-string "IRC Nick: "
 				(or (plist-get server-plist 'nick)
-				    rcirc-default-nick)))
+				    rcirc-default-nick)
+				'rcirc-history-nick-name))
 	     (channels (split-string
 			(read-string "IRC Channels: "
 				     (mapconcat 'identity
-- 
1.6.1.3

Message #14 received at 2737 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ryan Yeske  <rcyeske <at> gmail.com>
Cc: 2737 <at> debbugs.gnu.org
Subject: Re: [PATCH] Emacs CVS: (rcirc): Save call args to history variables
Date: Sun, 12 Jul 2009 15:00:51 -0400

Hi Ryan,

Jari Aalto wrote a patch to rcirc.el for saving the arguments to `rcirc'
to history.  Could you review it?  Thanks:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2737

Message #19 received at 2737 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Ryan Yeske <rcyeske <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 2737 <at> debbugs.gnu.org
Subject: Re: [PATCH] Emacs CVS: (rcirc): Save call args to history variables
Date: Sun, 12 Jul 2009 15:39:43 -0700

Chong Yidong <cyd <at> stupidchicken.com> writes:

> Hi Ryan,
>
> Jari Aalto wrote a patch to rcirc.el for saving the arguments to `rcirc'
> to history.  Could you review it?  Thanks:
>
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=2737

This is a useful change.  I tested the patch here, and it looks fine to
me.  Go ahead and apply it.

Message #24 received at 2737-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jari Aalto <jari.aalto <at> cante.net>
Cc: Ryan Yeske  <rcyeske <at> gmail.com>, 2737-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Emacs CVS: (rcirc): Save call args to history variables
Date: Wed, 15 Jul 2009 11:08:46 -0400

I've checked this patch into the trunk.  (I renamed your history
variables from rcirc-history-* to rcirc-*-history, for conformity.)

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.