GNU bug report logs - #27344
[PATCH 0/12] Add computational software and circuit simulators

Previous Next

Full log

Message #59 received at 27344 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Theodoros Foradis <theodoros.for <at> openmailbox.org>
Cc: 27344 <at> debbugs.gnu.org
Subject: Re: [bug#27344] [PATCH 08/12] gnu: Add ngspice.
Date: Thu, 15 Jun 2017 13:45:34 +0200

> +                   (license:non-copyleft "file://COPYING") ; spice3 bsd-style

This would mean the current directory of the current user on the remote host with name "COPYING".

I think you meant file:///COPYING which refers to the file "COPYING" on localhost.

> +           ((#:phases phases)
> +            `(alist-cons-after 'install 'in-ng

Please use modify-phases.

Please name the phase so that one can know what it does...

> +               (lambda* (#:key inputs outputs #:allow-other-keys)
> +                 (map (lambda (lib)
> +                        (copy-file
> +                         (string-append (assoc-ref inputs "libngspice")
> +                                        "/lib/" lib)
> +                         (string-append (assoc-ref outputs "out")
> +                                        "/lib/" lib)))
> +                      '("libngspice.so.0" "libngspice.so"))

Just use for-each...

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.