GNU bug report logs - #27331
[PATCH] Handle EIO error in ENOENT-safe as well.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Adam Van Ymeren <adam <at> vany.ca>
Subject: bug#27331: closed (Re: bug#27331: [PATCH] Handle EIO error in
 ENOENT-safe as well.)
Date: Sun, 11 Jun 2017 21:12:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#27331: [PATCH] Handle EIO error in ENOENT-safe as well.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 27331 <at> debbugs.gnu.org.

-- 
27331: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27331
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 27331-done <at> debbugs.gnu.org
Subject: Re: bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well.
Date: Sun, 11 Jun 2017 23:11:16 +0200

Hello,

Adam Van Ymeren <adam <at> vany.ca> skribis:

> Trying to boot GuixSD when an audio CD is in the drive will die with an
> "input/output error" when trying to read the superblock from the cd
> drive.
>
> This patch catches and warns in this case rather than dying.

Good catch!  I added a commit log following our conventions and
committed.

Thanks,
Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Adam Van Ymeren <adam <at> vany.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH] Handle EIO error in ENOENT-safe as well.
Date: Sun, 11 Jun 2017 13:01:31 -0400

Trying to boot GuixSD when an audio CD is in the drive will die with an
"input/output error" when trying to read the superblock from the cd
drive.

This patch catches and warns in this case rather than dying.
---
 gnu/build/file-systems.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 08f7d478e..f9cc4088b 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -419,6 +419,10 @@ warning and #f as the result."
                  #f)
                 ((= ENOMEDIUM errno)              ;for removable media
                  #f)
+                ((= EIO errno)                    ;unreadable hardware like audio CDs
+                 (format (current-error-port)
+                         "warning: failed to read from device '~a'~%" device)
+                 #f)
                 (else
                  (apply throw args))))))))

--
2.13.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.