GNU bug report logs - #27331
[PATCH] Handle EIO error in ENOENT-safe as well.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27331 in the body.
You can then email your comments to 27331 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Van Ymeren <adam <at> vany.ca>
To: guix-patches <at> gnu.org
Subject: [PATCH] Handle EIO error in ENOENT-safe as well.
Date: Sun, 11 Jun 2017 13:01:31 -0400

Trying to boot GuixSD when an audio CD is in the drive will die with an
"input/output error" when trying to read the superblock from the cd
drive.

This patch catches and warns in this case rather than dying.
---
 gnu/build/file-systems.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm
index 08f7d478e..f9cc4088b 100644
--- a/gnu/build/file-systems.scm
+++ b/gnu/build/file-systems.scm
@@ -419,6 +419,10 @@ warning and #f as the result."
                  #f)
                 ((= ENOMEDIUM errno)              ;for removable media
                  #f)
+                ((= EIO errno)                    ;unreadable hardware like audio CDs
+                 (format (current-error-port)
+                         "warning: failed to read from device '~a'~%" device)
+                 #f)
                 (else
                  (apply throw args))))))))

--
2.13.1

Message #10 received at 27331-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Adam Van Ymeren <adam <at> vany.ca>
Cc: 27331-done <at> debbugs.gnu.org
Subject: Re: bug#27331: [PATCH] Handle EIO error in ENOENT-safe as well.
Date: Sun, 11 Jun 2017 23:11:16 +0200

Hello,

Adam Van Ymeren <adam <at> vany.ca> skribis:

> Trying to boot GuixSD when an audio CD is in the drive will die with an
> "input/output error" when trying to read the superblock from the cd
> drive.
>
> This patch catches and warns in this case rather than dying.

Good catch!  I added a commit log following our conventions and
committed.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.